Why does TupleDescInitBuiltinEntry lack a "default: error" case?
Started by Tom Laneover 7 years ago2 messageshackers
If the passed-in type OID isn't one of the very short list that
TupleDescInitBuiltinEntry supports, it will silently hand back
a broken TupleDesc, rather than throwing an error. How can
this possibly be considered good code?
(So far as I can see, none of the extant callers could hit
such an error, but it's still bad code.)
regards, tom lane
Re: Why does TupleDescInitBuiltinEntry lack a "default: error" case?
Hi,
On 2018-12-09 14:49:35 -0500, Tom Lane wrote:
If the passed-in type OID isn't one of the very short list that
TupleDescInitBuiltinEntry supports, it will silently hand back
a broken TupleDesc, rather than throwing an error. How can
this possibly be considered good code?
+1
Greetings,
Andres Freund