Can we remove the #fdef UNUSED code from nbtxlog.c

Started by Andres Freundover 7 years ago2 messageshackers

andres@anarazel.de

over 7 years ago

Hi,

nbtxlog.c has a fairly large section of code commented out with #ifdef
UNUSED. With a node justifying that with:

+    * This section of code is thought to be no longer needed, after
+    * analysis of the calling paths. It is retained to allow the code
+    * to be reinstated if a flaw is revealed in that thinking.

That seems much better addressed by git revert/git log. Having a
comment explaining facts that aren't true anymore is just plain
confusing.

Greetings,

Andres Freund

Michael Paquier

michael@paquier.xyz

over 7 years ago

In reply to: Andres Freund (#1)

Re: Can we remove the #fdef UNUSED code from nbtxlog.c

On Thu, Dec 13, 2018 at 03:28:15PM -0800, Andres Freund wrote:

nbtxlog.c has a fairly large section of code commented out with #ifdef
UNUSED. With a node justifying that with:
+    * This section of code is thought to be no longer needed, after
+    * analysis of the calling paths. It is retained to allow the code
+    * to be reinstated if a flaw is revealed in that thinking.

This comes from 3e4b7d87.

That seems much better addressed by git revert/git log. Having a
comment explaining facts that aren't true anymore is just plain
confusing.

+1.  It seems to me as well that this is better if just deleted.
--
Michael