Jan 2021

2 commits
Fix COPY FREEZE with CLOBBER_CACHE_ALWAYS
24 Jan 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #641 of 1 reviewer saw the final version

Extracts the previously omitted heap_insert handling, heap_xlog_multi_insert visibility update, and hio.c last-page fallback from #64, with small comment and defensive-initialization edits. Tomas explains the mistaken earlier landing in #70 and confirms this restoration in #71.

  • Tomas Vondrasaw the final versioncommittercommitted the patch
Set PD_ALL_VISIBLE and visibility map bits in COPY FREEZE
17 Jan 2021Tomas Vondramaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1Also in: COPY FREEZE and PD_ALL_VISIBLE
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #591 of 9 reviewers saw the final version

Matches the older submission #59, as Tomas explicitly confirms in #70, with an added comment and a visibility-setting replay hunk relocated from heap_xlog_multi_insert to heap_xlog_insert. Anastasia's implementation was forwarded by Tomas, and this matching submission is newer than the historical patch in thread #33624.

  • Kuntal Ghoshsaw an earlier versiontrailerProposed setting PD_ALL_VISIBLE during insertion into new pages in #2 and #4, before the subsequent architectural rewrites.
  • Jeff Janessaw an earlier versiontrailerTested #1 with large TOAST values and reported intermittently unfrozen blocks in #5, before the implementation was rewritten.
  • Tomas Vondrasaw the final versiontrailerReviewed architecture, benchmarked workloads, tested TOAST and trigger cases, and reviewed #64 in #65; as committer, his coverage includes the committed version.
  • Masahiko Sawadasaw an earlier versiontrailerQuestioned rescanning costs, requested conditional dirtying and regression tests in #15, and reviewed the revision in #17 before the architectural rewrites.
  • Andres Freundsaw an earlier versiontrailerCriticized heap-specific COPY hooks and extra scan/locking work in #20 and #22, then supplied the insertion-time prototype #34 that was subsequently reworked.
  • Ibrar Ahmedsaw an earlier versiontrailerBenchmarked the revised implementation in #46 and #53, before later pin-handling changes and the replay-hunk relocation at commit.
  • Robert Haassaw an earlier versiontrailerChallenged the duplicate WAL flags, copied replay comments, and recptr workaround in #44, prompting the WAL-handling rework.
  • Tatsuro Ishiisaw an earlier versiontrailerPosting as Tatsuo Ishii, reported performance testing and suggested a comment correction in #55, before subsequent pin-handling and committed replay changes.
  • Darafei Praliaskouskisaw an earlier versiontrailerExplicitly reported reading the patch and explained its OpenStreetMap workload benefit in #14, before the architectural rewrites.

Credits across 2 commits

Author
Anastasia Lubennikova1 LLM2
Jeff Janes1
Pavan Deolasee1
Reviewer
Tomas Vondracommitter2
Andres Freund1
Darafei "Komяpa" Praliaskouski1
Ibrar Ahmed1
Jeff Janes1
Kuntal Ghosh1
Masahiko Sawada1
Robert Haas1
Tatsuo Ishii1
Committer
Tomas Vondra2

N LLM means N of the credits come from LLM analysis, not from commit trailers.