Small doc fix for pageinspect

Started by Laurenz Albeabout 7 years ago3 messageshackers
Jump to latest
#1Laurenz Albe
laurenz.albe@cybertec.at

I noticed today that the signature for two functions is wrong
in the documentation:

- "heap_page_item_attrs" has the argument order and return type wrong
and is lacking types

- "tuple_data_split" is lacking the type for "rel_oid"

Patch attached.

This should be backpatched down to 9.6 where the functions have been added.

Yours,
Laurenz Albe

Attachments:

0001-Fix-documentation-of-pageinspect-function-signatures.patchtext/x-patch; charset=UTF-8; name=0001-Fix-documentation-of-pageinspect-function-signatures.patchDownload+2-3
#2Michael Paquier
michael@paquier.xyz
In reply to: Laurenz Albe (#1)
Re: Small doc fix for pageinspect

On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:

This should be backpatched down to 9.6 where the functions have been
added.

Thanks, applied. The second argument name of heap_page_item_attrs is
actually "page", and not "t_data", so both your patch and the docs
were wrong on this point.
--
Michael

#3Laurenz Albe
laurenz.albe@cybertec.at
In reply to: Michael Paquier (#2)
Re: Small doc fix for pageinspect

Michael Paquier wrote:

On Thu, Mar 07, 2019 at 09:00:24PM +0100, Laurenz Albe wrote:

This should be backpatched down to 9.6 where the functions have been
added.

Thanks, applied. The second argument name of heap_page_item_attrs is
actually "page", and not "t_data", so both your patch and the docs
were wrong on this point.

Thanks, and pardon the sloppiness.

Yours,
Laurenz Albe