Apr 2019

2 commits
Reset memory context once per tuple in validateForeignKeyConstraint.
8 Apr 2019Andres Freundmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 moreAlso in: tableam scan-API patch broke foreign key validation (not this thread)Also in: Shouldn't validateForeignKeyConstraint() reset memory context?
LLM analysis, 98% surepart of a posted patchsetmoderate changesfrom patchset #30 of 1 reviewer saw the final version

This commits the memory-context, interrupt-check, and tg_newslot portions of #3 in src/backend/commands/tablecmds.c; the tuple-materialization fix had already landed separately. It moves MemoryContextSwitchTo() before the loop, correctly preserving the original context even for an empty scan, and #4 confirms the split landing.

  • Tom Laneno review foundtrailerThe commit credits Tom Lane with reviewing an earlier version, but this thread contains no message from him establishing patchset review coverage.
Fix failures in validateForeignKeyConstraint's slow path.
6 Apr 2019Tom Lanemaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+2 moreAlso in: tableam scan-API patch broke foreign key validation (modified before commit)Also in: Fix foreign key constraint check for partitioned tables (not this thread)

Credits across 2 commits

Author
Andres Freund1
Tom LaneLLM1
Reviewer
Tom Lane1
Committer
Andres Freund1
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.