May 2019

2 commits
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir.
23 May 2019Andres Freundmaster12beta2REL_19_STABLE12beta2REL_18_STABLE12beta2REL_17_STABLE12beta2REL_16_STABLE12beta2REL_15_STABLE12beta2REL_14_STABLE12beta2REL_13_STABLE12beta2+6 more
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit implements the inline fix proposed in #11 and refined in #17: unconditionally append --bindir='$oldbindir' to EXTRA_REGRESS_OPTS in src/bin/pg_upgrade/test.sh. Neither attached patchset contains this fix.

  • Tom Lanesaw the final versionLLM analysis, 96% sureAfter the inline proposal in #11, Tom examined cross-version behavior and explained in #14 why the earlier branch's psql should run its regression tests, matching the committed oldbindir choice.
pg_upgrade: Don't use separate installation for test.
21 May 2019Andres Freundmaster12beta2REL_19_STABLE12beta2REL_18_STABLE12beta2REL_17_STABLE12beta2REL_16_STABLE12beta2REL_15_STABLE12beta2REL_14_STABLE12beta2REL_13_STABLE12beta2+1 moreAlso in: pgsql: Make VACUUM accept 1 and 0 as a boolean value. (part of a posted patchset)

Mar 2019

1 commit
Have pg_upgrade's Makefile honor NO_TEMP_INSTALL
31 Mar 2019Andrew Dunstanmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+5 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #11 of 1 reviewer saw the final version

The commit preserves both Makefile hunks from #1, adding only double quotes around the tbindir and tlibdir values passed to test.sh. Those edits implement Tom Lane's review in #3.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom requested double quotes around the path assignments in #3, and that precise correction was included in the committed patch.

Credits across 3 commits

Author
Andres Freund2
Andrew DunstanLLM1
Reviewer
Tom Lane1
Committer
Andres Freund2
Andrew Dunstan1

N LLM means N of the credits come from LLM analysis, not from commit trailers.