Inaccurate header comment of issue_xlog_fsync_comment

Started by Antonin Houskaover 6 years ago2 messages
#1Antonin Houska
ah@cybertec.at
1 attachment(s)

Someone probably forgot to update the comment when changing the arguments.

--
Antonin Houska
Web: https://www.cybertec-postgresql.com

Attachments:

issue_xlog_fsync_comment.patchtext/x-diffDownload
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index c00b63c751..527522f165 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -10065,7 +10065,7 @@ assign_xlog_sync_method(int new_sync_method, void *extra)
  * Issue appropriate kind of fsync (if any) for an XLOG output file.
  *
  * 'fd' is a file descriptor for the XLOG file to be fsync'd.
- * 'log' and 'seg' are for error reporting purposes.
+ * 'segno' is for error reporting purposes.
  */
 void
 issue_xlog_fsync(int fd, XLogSegNo segno)
#2Fujii Masao
masao.fujii@gmail.com
In reply to: Antonin Houska (#1)
Re: Inaccurate header comment of issue_xlog_fsync_comment

On Mon, May 20, 2019 at 11:04 PM Antonin Houska <ah@cybertec.at> wrote:

Someone probably forgot to update the comment when changing the arguments.

Thanks for the patch! Committed.

Regards,

--
Fujii Masao