Oct 2020

4 commits
Minor cleanup for win32stat.c.
12 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Changes the CreateFile failure branch in src/port/win32stat.c to preserve GetLastError and call _dosmaperr instead of forcing ENOENT, exactly addressing Michael Paquier's proposal in #37. Juan agreed in #39, and Tom confirmed the change in #40; no attachment contains this fix.

Minor cleanup for win32stat.c.
10 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Corrects nFileSizeLowi to nFileSizeLow in src/port/win32stat.c after c94cfb38c3; the attached cleanup itself contains the typo. Tom identifies this already-committed correction in #36, responding to the later buildfarm report in #35.

Minor cleanup for win32stat.c.
10 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #302 of 2 reviewers saw the final version

Takes the error-preservation and expression-formatting hunks from #30, omitting its special handling of missing-file errors and additionally reformatting PFN_NTQUERYINFORMATIONFILE. Michael objected to the omitted branch in #31, and Tom explicitly confirmed committing the remainder in #33.

  • Michael Paquiersaw the final versionLLM analysis, 100% sureReviewed #30 in #31, identifying redundant error mapping and supporting preservation of the original error across CloseHandle, with his objection incorporated before commit.
  • Tom Lanesaw the final versioncommittercommitted the patch
Fix our Windows stat() emulation to handle file sizes > 4GB.
9 Oct 2020Tom Lanemaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.17Also in: stat() on Windows might cause error if target file is larger than 4GB
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #222 of 2 reviewers saw the final version

Matches #22 across the Windows header, build integration, dirmod.c removal, and new win32stat.c, with comment/formatting edits, unsigned size arithmetic, and GetFileAttributes error mapping suggested in #28. This matching September 2020 patchset is newer than the September 2018 submissions in thread #39332.

  • Emil Igglandsaw the final versionLLM analysis, 100% sureTested the earlier implementation in #15, then tested and reviewed #22 in #28, proposing the error-mapping change incorporated into the commit.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 4 commits

Author
Juan José Santamaría FlechaLLM2
Alexandra Wang1
Reviewer
Tom Lanecommitter2
Andrew Dunstancommitter1
Committer
Tom Lane4
Andrew Dunstan1

N LLM means N of the credits come from LLM analysis, not from commit trailers.