MAKEFLAGS in non-GNU Makefile

Started by Thomas Munroalmost 7 years ago2 messageshackers
Jump to latest
#1Thomas Munro
thomas.munro@gmail.com

Hi,

In commit a76200de we added a line to unset MAKELEVEL to fix a problem
with our temp-install logic. I don't think it was a great idea to
clear MAKEFLAGS at the same time, because now when you type "make -s
-j8" on a non-GNU system it ignores you and is loud and slow.
Admittedly there is something slightly weird about passing flags to
both makes, but in the case of widely understood flags like those
ones, it works fine.

--
Thomas Munro
https://enterprisedb.com

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Thomas Munro (#1)
Re: MAKEFLAGS in non-GNU Makefile

Thomas Munro <thomas.munro@gmail.com> writes:

In commit a76200de we added a line to unset MAKELEVEL to fix a problem
with our temp-install logic. I don't think it was a great idea to
clear MAKEFLAGS at the same time, because now when you type "make -s
-j8" on a non-GNU system it ignores you and is loud and slow.

Feel free to undo that. I was concerned about possible incompatibilities
in the makeflags, but if typical cases like this one seem to work, let's
allow it.

regards, tom lane