Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

Started by Michael Paquieralmost 7 years ago4 messageshackers
Jump to latest
#1Michael Paquier
michael@paquier.xyz

Hi all,

We have been using RAND_OpenSSL(), a function new as of OpenSSL 1.1.0
in pgcrypto until fe0a0b5 which has removed the last traces of the
function in the tree. We still have a configure check for it and the
related compilation flag in pg_config.h.in, and both are now useless.

Any objections to the cleanup done in the attached patch?

Thanks,
--
Michael

Attachments:

rand-openssl-cleanup.patchtext/x-diff; charset=us-asciiDownload+2-5
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Michael Paquier (#1)
Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

On 26 Jun 2019, at 16:25, Michael Paquier <michael@paquier.xyz> wrote:

Any objections to the cleanup done in the attached patch?

None, LGTM.

cheers ./daniel

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#1)
Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

Michael Paquier <michael@paquier.xyz> writes:

We have been using RAND_OpenSSL(), a function new as of OpenSSL 1.1.0
in pgcrypto until fe0a0b5 which has removed the last traces of the
function in the tree. We still have a configure check for it and the
related compilation flag in pg_config.h.in, and both are now useless.

Any objections to the cleanup done in the attached patch?

+1, fewer configure checks always better. I don't see any other
references to RAND_OpenSSL either.

regards, tom lane

#4Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#2)
Re: Useless configure checks for RAND_OpenSSL (HAVE_RAND_OPENSSL)

On Wed, Jun 26, 2019 at 04:35:43PM +0200, Daniel Gustafsson wrote:

None, LGTM.

Thanks, committed.
--
Michael