Sep 2019

1 commit
Remove mingwcompat.c
17 Sep 2019Peter Eisentrautmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The commit deletes src/backend/port/win32/mingwcompat.c and removes mingwcompat.o from its Makefile, implementing Peter Eisentraut's proposal in #5, announced committed in #8. The attached patchset #1 only changes pg_basebackup.c.

Jul 2019

1 commit
Fix compilation warning of pg_basebackup with MinGW
21 Jul 2019Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #11 of 1 reviewer saw the final version

Both hunks in src/bin/pg_basebackup/pg_basebackup.c exactly match #1, adding WIN32 guards around filemode's declaration and assignment. Michael Paquier confirmed applying the fix only on HEAD in #4.

  • Andrew Dunstansaw the final versiontrailerAndrew gave a +1 in #2, alongside analysis of the separate MinGW import warning, and the commit credits his review of the unchanged patchset #1.

Credits across 2 commits

Author
Michael Paquier1
Reviewer
Andrew Dunstan1
Committer
Michael Paquier1
Peter Eisentraut1