pqParseInput3 overruns

Started by Kyotaro Horiguchiabout 7 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t40985
psql -h localhost -U postgres

Built from patchset v1 (message #1), October 23, 2026 at 01:19 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t40985_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t40985_1 && git checkout t40985_1

Patchset v1 (message #1) is on t40985_1

Jump to latest
#1Kyotaro Horiguchi
horikyota.ntt@gmail.com

Hello.

While looking [1]/messages/by-id/alpine.DEB.2.21.1904132231510.8961@lancre, I noticed that NOTICE messages of the next
command is processed before PQgetResult returns. Clients can
receive such spurious NOTICE messages.

Looking pqParseInput3, its main loop seems considered to exit
after complete messages is processed. (As I read.)

* Loop to parse successive complete messages available in the buffer.

But actually, 'C' message doesn't work that way. I think we
should do as the comment suggests. Clients still can process
async messages or (somehow issued) NOTICE messages in later
calls.

[1]: /messages/by-id/alpine.DEB.2.21.1904132231510.8961@lancre

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachments:

t40985_1
0001-Don-t-parse-further-messages-after-COMPLETE-message.patchtext/x-patch; charset=us-asciiDownload+4-1