Fwd: [PATCH] Absolute passwordfile path

Started by Danylo Hlynskyiover 6 years ago3 messages
#1Danylo Hlynskyi
abcz2.uprola@gmail.com

The pool_passwd option [1]http://www.pgpool.net/docs/latest/en/html/runtime-config-connection.html#GUC-POOL-PASSWD is specified relative to config file. But for
greater flexibility absolute path should be accepted as well.

If pool_passwd option starts with /, let's treat it as absolute path.
Otherwise, it is treated as relative path.

Patch attached. Original author - Derek Kulinski [2]https://github.com/NixOS/nixpkgs/pull/66224. In NixOS,
configuration files often end up in world readable store, which is not the
best place for storing password files.

[1]: http://www.pgpool.net/docs/latest/en/html/runtime-config-connection.html#GUC-POOL-PASSWD
http://www.pgpool.net/docs/latest/en/html/runtime-config-connection.html#GUC-POOL-PASSWD
[2]: https://github.com/NixOS/nixpkgs/pull/66224

#2Amit Langote
amitlangote09@gmail.com
In reply to: Danylo Hlynskyi (#1)
Re: [PATCH] Absolute passwordfile path

Hello,

On Wed, Aug 7, 2019 at 3:05 PM Danylo Hlynskyi <abcz2.uprola@gmail.com> wrote:

The pool_passwd option [1] is specified relative to config file. But for greater flexibility absolute path should be accepted as well.

If pool_passwd option starts with /, let's treat it as absolute path. Otherwise, it is treated as relative path.

Patch attached. Original author - Derek Kulinski [2]. In NixOS, configuration files often end up in world readable store, which is not the best place for storing password files.

[1] http://www.pgpool.net/docs/latest/en/html/runtime-config-connection.html#GUC-POOL-PASSWD
[2] https://github.com/NixOS/nixpkgs/pull/66224

Did you mean to send this email to pgpool-hackers@pgpool.net or
somewhere else like a NixOS mailing list, not
pgsql-hackers@lists.postgresql.org? This list is used to discuss the
topics related to PostgreSQL development.

Regards,
Amit

#3Danylo Hlynskyi
abcz2.uprola@gmail.com
In reply to: Amit Langote (#2)
Re: [PATCH] Absolute passwordfile path

Yes, I've resent it to pgpool-hackers@pgpool.net
Sorry for the noise
<pgpool-hackers@pgpool.net>

ср, 7 серп. 2019 о 09:18 Amit Langote <amitlangote09@gmail.com> пише:

Show quoted text

Hello,

On Wed, Aug 7, 2019 at 3:05 PM Danylo Hlynskyi <abcz2.uprola@gmail.com>
wrote:

The pool_passwd option [1] is specified relative to config file. But for

greater flexibility absolute path should be accepted as well.

If pool_passwd option starts with /, let's treat it as absolute path.

Otherwise, it is treated as relative path.

Patch attached. Original author - Derek Kulinski [2]. In NixOS,

configuration files often end up in world readable store, which is not the
best place for storing password files.

[1]

http://www.pgpool.net/docs/latest/en/html/runtime-config-connection.html#GUC-POOL-PASSWD

[2] https://github.com/NixOS/nixpkgs/pull/66224

Did you mean to send this email to pgpool-hackers@pgpool.net or
somewhere else like a NixOS mailing list, not
pgsql-hackers@lists.postgresql.org? This list is used to discuss the
topics related to PostgreSQL development.

Regards,
Amit