Apr 2020

13 commits
Try to avoid compiler warnings in optimized builds.
24 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #3101 of 1 reviewer saw the final version

The pg_attribute_noreturn() addition in src/bin/pg_verifybackup/parse_manifest.h exactly matches #310.

  • Andres Freundsaw the final versionLLM analysis, 100% sureAfter reporting the warning, he independently tested the attached fix and confirmed that it worked in #311.
Fix option related issues in pg_verifybackup.
23 Apr 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #3071 of 1 reviewer saw the final version

The option-table removal and usage corrections in pg_verifybackup.c exactly match #307.

  • Robert Haassaw the final versiontrailerAcknowledged the posted option cleanup with LGTM in #308, and the committed patch is unchanged.
Add index term for backup manifest in documentation.
17 Apr 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #2991 of 1 reviewer saw the final version

The four-line indexterm addition in doc/src/sgml/backup-manifest.sgml exactly matches #299.

  • Robert Haassaw the final versiontrailerAccepted the proposed index improvement in #300, with no subsequent patch changes.
Code review for backup manifest.
15 Apr 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surelanded as postedfrom patchset #2722 of 2 reviewers saw the final version

Combines all three attachments from #272 unchanged: conditional manifest reception, removal of unused -m, and BASE_BACKUP documentation fixes.

  • Michael Paquiersaw the final versiontrailerReproduced the --no-manifest tar/stdout failure and examined the documentation corrections in #273.
  • Robert Haassaw the final versiontrailerConfirmed the proposed fixes in #274, after which all three patches landed unchanged.
Document the backup manifest file format.
14 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #2775 of 5 reviewers saw the final version

Uses the format chapter from #277, adding the rationale for fixed SHA256 and refining Timeline, End-LSN, and hexadecimal wording.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureIdentified spelling errors in #276 that were corrected in #277, with only light documentation changes afterward.
  • Erik Rijkerssaw the final versionLLM analysis, 100% sureFlagged Timeline wording and the phrase making using in #278, both corrected before commit.
  • Álvaro Herrerasaw the final versionLLM analysis, 100% sureIdentified the hexadecimal typo and examined the checksum and format specification in #279.
  • Andrew Dunstansaw the final versionLLM analysis, 100% sureRequested an example in #281 and is explicitly credited as a reviewer by 149f2ae88a.
  • David Steelesaw the final versionLLM analysis, 98% sureProposed explaining the fixed SHA256 choice in #284, and that explanation appears in the committed chapter.
Fix typo in pg_validatebackup documentation.
9 Apr 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2621 of 1 reviewer saw the final version

Exactly commits the pg_validatebackup documentation typo attachment from #262; the stale-manifest exclusion attachment landed separately.

  • Robert Haassaw the final versiontrailerEndorsed both attached fixes in #263, including the unchanged documentation correction.
Exclude backup_manifest file that existed in database, from BASE_BACKUP.
9 Apr 2020Fujii Masaomaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2621 of 1 reviewer saw the final version

Commits the backup_manifest exclusions in basebackup.c and pg_rewind/filemap.c from #262, with comment rewrapping; the documentation attachment is separate.

  • Robert Haassaw the final versiontrailerReviewed and endorsed the stale-manifest exclusion in #263, followed only by comment formatting.
Msys2 tweaks for pg_validatebackup corruption test
8 Apr 2020Andrew Dunstanmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #2640 of 2 reviewers saw the final version

Reworks #264 by correcting its path-prefix regex and replacing unconditional unlink with a Windows rmdir-then-unlink fallback in 003_corruption.pl.

  • Tom Lanesaw an earlier versionLLM analysis, 98% sureFlagged risks to other Windows hosts in #265 and requested an MSYS2 reference in #268, before the fallback logic was rewritten.
  • Robert Haassaw an earlier versionLLM analysis, 98% sureExplained in #266 that Windows testing required retaining rmdir, prompting the subsequently committed fallback implementation.
pg_validatebackup: Fix 'make clean' to remove tmp_check.
3 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Adds removal of tmp_check to pg_validatebackup's Makefile after Tom Lane's cleanup report in #227; no matching attachment was posted.

pg_validatebackup: Also use perl2host in TAP tests.
3 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Wraps both corruption-test temporary paths with TestLib::perl2host following Álvaro's suggestion in #222 and Robert's response in #223, without an attached patch.

Generate backup manifests for base backups, and validate them.
3 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2121 of 10 reviewers saw the final version

Combines the main feature and checksum-time size-check patches from #212, leaving its two prerequisite patches to separate commits. Additional edits remove a debugging fprintf in parse_manifest.c and correct a documentation typo.

  • vignesh Csaw an earlier versionLLM analysis, 98% sureIdentified compiler warnings, pg_gmtime failure handling, and manifest omissions in #17, before the validator and format were substantially rewritten.
  • Jeevan Chalkesaw an earlier versionLLM analysis, 98% sureReviewed generator state handling and validator parsing/hash code in #26, #27, and #52, before the standalone JSON rewrite.
  • tusharsaw an earlier versionLLM analysis, 99% sureTested invalid paths, permissions, ignored paths, and old-server behavior in #97, #99, and #109, before WAL verification was added.
  • Suraj Kharagesaw an earlier versionLLM analysis, 94% sureReviewed Robert's rewritten implementation, finding misplaced backend changes in #108 and proposing accepted format-attribute corrections in #116.
  • Rajkumar Raghuwanshisaw an earlier versionLLM analysis, 93% sureTested Robert's rewritten validator with a negative manifest file size and reported its misleading unsigned-size diagnostic in #104.
  • Amit Kapilasaw an earlier versionLLM analysis, 100% sureRan Windows tests and supplied the algorithm-option correction in #121 and tablespace-junction fix in #127, before WAL support was added.
  • Stephen Frostsaw an earlier versionLLM analysis, 99% sureReviewed command syntax and documentation and challenged missing required-WAL verification in #123, prompting substantial subsequent changes.
  • David Steelesaw an earlier versionLLM analysis, 96% sureTested malformed manifests and reviewed code and documentation in #152 and #196, before WAL verification and completion-publication changes.
  • Noah Mischsaw an earlier versionLLM analysis, 99% sureExamined memory handling and proposed publishing the manifest only after successful backup completion in #174, implemented later in #208.
  • Andres Freundsaw the final versionLLM analysis, 99% sureReviewed WAL handling in #202, requested checksum-time byte counting in #211, and confirmed the resulting final delta in #213.
Add checksum helper functions.
3 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2121 of 1 reviewer saw the final version

Exactly matches the checksum-helper component of #212, including checksum_helper.c, its header, and Unix/MSVC build integration.

  • Suraj Kharagesaw the final versionLLM analysis, 100% sureThe message for c12e43a2e0 explicitly credits his off-list review of Robert's rewritten helper implementation.
pg_waldump: Add a --quiet option.
3 Apr 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #2121 of 1 reviewer saw the final version

Matches the pg_waldump --quiet component of #212, with one documentation spelling correction. The commit credits Andres and Robert, and Andres supplied its prototype in #184.

  • Robert Haassaw the final versioncommittercommitted the patch

Dec 2019

1 commit
pg_basebackup: Refactor code for reading COPY and tar data.
5 Dec 2019Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #47

Commits the COPY/tar refactoring component of #47 with only formatting and context differences. Robert originated it in #15 and corrected the forwarded authorship in #48.

Credits across 14 commits

Author
Fujii Masao5
Robert HaasLLM5
Andres FreundLLM1
Andrew DunstanLLM1
Reviewer
Robert Haascommitter6
Michael Paquier1
Committer
Robert Haas8
Fujii Masao5
Andrew Dunstan1

N LLM means N of the credits come from LLM analysis, not from commit trailers.