remove useless returns

Started by Alvaro Herreraover 6 years ago2 messageshackers
Jump to latest
#1Alvaro Herrera
alvherre@2ndquadrant.com

Here's a silly insomnia-inspired little patch that removes useless
"return;" lines from some routines. (I left some alone, because they
seemed to be there more for documentation purposes, such as the ones in
from_char_set_mode and from_char_set_int; also regcomp.c since the
pedigree there is unclear.)

This seems pretty uncontroversial, so I'm not thinking of waiting over
the US holidays to get opinions about it ...

--
�lvaro Herrera PostgreSQL Expert, https://www.2ndQuadrant.com/

Attachments:

0001-Remove-useless-return-lines.patchtext/x-diff; charset=us-asciiDownload+0-83
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Alvaro Herrera (#1)
Re: remove useless returns

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

Here's a silly insomnia-inspired little patch that removes useless
"return;" lines from some routines.

+1, I always thought that was poor style.

regards, tom lane