Jan 2020

9 commits
Add jsonapi.c to Mkvcbuild.pm's @pgcommonallfiles.
29 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #941 of 1 reviewer saw the final version

Extracts exactly the @pgcommonallfiles hunk adding jsonapi.c from #94 in src/tools/msvc/Mkvcbuild.pm; the test-program hunks remain uncommitted, as Robert explains in #98.

  • Robert Haassaw the final versioncommittercommitted the patch
Move jsonapi.c and jsonapi.h to src/common.
29 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #922 of 3 reviewers saw the final version

Commits the parser-relocation component of #92, leaving its frontend tests pending. Changes within that component only consolidate the pg_wchar.h include and wrap the macro definition, consistent with #95.

  • David Steelesaw an earlier versionLLM analysis, 98% sureTested frontend callbacks with multiple JSON types, an escape, and a multibyte character in #20, before substantial error-handling and encoding-interface changes.
  • Andrew Dunstansaw the final versionLLM analysis, 96% sureReviewed the frontend extension in #46 and identified missing Windows build integration for the final relocation in #94.
  • Robert Haassaw the final versioncommittercommitted the patch
Move some code from jsonapi.c to jsonfuncs.c.
27 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #272 of 2 reviewers saw the final version

Exactly matches the fifth patch of #27 by stable patch ID, moving backend-dependent helpers and declarations from jsonapi.c/jsonapi.h to jsonfuncs.c/jsonfuncs.h; it is one component of that five-patch series.

  • Mark Dilgersaw the final versionLLM analysis, 100% sureIntegrated and benchmarked the series in #45, confirmed review of its final two patches in #65, and is explicitly credited in the commit.
  • Andrew Dunstansaw the final versionLLM analysis, 100% sureExplicitly reviewed the latest helper-relocation patch in #67 and is credited as a reviewer in the commit.
Adjust pg_parse_json() so that it does not directly ereport().
27 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #272 of 3 reviewers saw the final version

Exactly matches the fourth patch of #27 by stable patch ID, introducing parser error returns and backend error-reporting wrappers; the commit takes that component of the five-patch series.

  • David Steelesaw an earlier versionLLM analysis, 94% sureExamined error-message deduplication, the invalid-escape case, and wrapper naming in #25, before the public interfaces and surrounding call sites were reworked.
  • Mark Dilgersaw the final versionLLM analysis, 100% sureIntegrated and benchmarked the return-code implementation in #45, confirmed his review in #65, and is credited in the commit.
  • Andrew Dunstansaw the final versionLLM analysis, 100% sureConfirmed review of the latest return-code patch in #67 and is credited in the commit.
Remove jsonapi.c's lex_accept().
24 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #273 of 3 reviewers saw the final version

Exactly matches the third patch of #27 by stable patch ID, removing lex_accept() and inlining its specialized uses in src/backend/utils/adt/jsonapi.c.

  • David Steelesaw the final versionLLM analysis, 99% sureResponded to the lex_accept() removal in #25 and receives explicit reviewer credit in the commit; that component remained unchanged in #27.
  • Mark Dilgersaw the final versionLLM analysis, 100% sureIntegrated and benchmarked the parser changes in #45 and receives explicit reviewer credit in the commit.
  • Andrew Dunstansaw the final versionLLM analysis, 100% sureSpecifically discussed inlining the parser's accept helper while reviewing Robert's patches in #46 and is credited in the commit.
Split JSON lexer/parser from 'json' data type support.
24 Jan 2020Robert Haasmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #273 of 3 reviewers saw the final version

Exactly matches the second patch of #27 by stable patch ID, splitting the lexer/parser from json.c into jsonapi.c with corresponding Makefile and header changes.

  • David Steelesaw the final versionLLM analysis, 100% sureReported code examination and frontend testing in #20 and #21, and the parser-split component stayed unchanged through #27.
  • Mark Dilgersaw the final versionLLM analysis, 100% sureIntegrated and benchmarked the split parser in #45 and is explicitly credited as a reviewer in the commit.
  • Andrew Dunstansaw the final versionLLM analysis, 100% sureConfirmed review of Robert's patches in #46 and is explicitly credited as a reviewer in the commit.
Rationalize code placement between wchar.c, encnames.c, and mbutils.c.
16 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements Tom's follow-up plan in #17: move backend-only encoding routines into mbutils.c and make ICU name lookup return NULL. No attached patch contains this change; the commit also removes pg_mic_mblen and the overlength-name error.

Update header comments for wchar.c and encnames.c.
16 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #14

Contains only the wchar.c and encnames.c header-comment changes from #14, separated from their relocation. Both resulting source files exactly match the full added-file contents in that submission.

Move wchar.c and encnames.c to src/common/.
16 Jan 2020Tom Lanemaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #14

Takes the relocation and build-system portions of #14, moving wchar.c and encnames.c verbatim into src/common. Its posted copyright/header changes were split into 3d4cb5d6c1.

Credits across 9 commits

Author
Robert HaasLLM4
Tom LaneLLM2
Andrew DunstanLLM1
Mark DilgerLLM1
Reviewer
Robert Haascommitter2
Committer
Robert Haas6
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.