ALTER TEXT SEARCH DICTIONARY tab completion
"ALTER TEXT SEARCH DICTIONARY foobar" can be followed by an open
parenthesis, but that is not offered in tab completion. That is useful,
because otherwise I have to look up the docs to see if I need a SET or
OPTION(S) or WITH or something before it, just to discover I don't.
The attached one-line patch adds "(".
We can't go beyond that, as available options for each dictionary are not
known in advance.
Cheers,
Jeff
Attachments:
alter_dict_tab_complete.patchapplication/octet-stream; name=alter_dict_tab_complete.patchDownload+1-1
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
It looks good and does what it says on the tin.
One minor nitpick I feel I should add is that for completeness and
balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should
get the same treatment.
Maybe something along the lines of:
- else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny))
+ else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))
Georgios Kokolatos <gkokolatos@pm.me> writes:
One minor nitpick I feel I should add is that for completeness and
balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should
get the same treatment.
Maybe something along the lines of: - else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny)) + else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))
Agreed; actually all four CREATE TEXT SEARCH commands could do that.
I pushed it as attached.
regards, tom lane