AW: AW: AW: Modified pg_dump & new pg_restore need test ing...
Philip Warner [mailto:pjw@rhyme.com.au] wrote:
At 10:39 3/07/00 +0200, Zeugswetter Andreas SB wrote:
Could the text format be changed in a compatible way,
that would allow pg_restore's features ? I am thinking ofinserted comment
lines that describe the needed sections.
Quite possibly; although part of my motivation in writing to
the new format
was to avoid writing a text parser.
Yes, you are probably right.
There is no reason why it couldn't use
a text file by doing a pass through the file to construct a
TOC, but this
seems like a bad idea for large backups, and not really
necessary for small
backups (especially with the -Z option).That said, I'm happy to give it a go - the output file is
already pretty
'parsable'.
I guess it is probably really not worth the trouble.
Imho the new default format does not need to be compatible
with pg_dump's output. I would still not compress by default.I'm happy to do this; at the moment it uses zlib default
compression by
Do we already check for zlib ? It is probably not available everywhere.
Andreas
At 10:56 3/07/00 +0200, Zeugswetter Andreas SB wrote:
Do we already check for zlib ? It is probably not available everywhere.
That may be true - although I thought it was pretty universal.
I will have a look at using something 'HAVE_ZLIB' setting to enable/disable
compressed output...I presume 'configure' needs to be changed? Is that right?
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.C.N. 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
On Mon, 3 Jul 2000, Philip Warner wrote:
At 10:56 3/07/00 +0200, Zeugswetter Andreas SB wrote:
Do we already check for zlib ? It is probably not available everywhere.
That may be true - although I thought it was pretty universal.
I will have a look at using something 'HAVE_ZLIB' setting to enable/disable
compressed output...I presume 'configure' needs to be changed? Is that right?
that will be correct, but its a quick/easy change ... I'll add the code in
tonight so that its something we check for and set in config.h, so as long
as you include that, you'll have that setting available ...
At 22:39 3/07/00 -0300, The Hermit Hacker wrote:
that will be correct, but its a quick/easy change ... I'll add the code in
tonight so that its something we check for and set in config.h, so as long
as you include that, you'll have that setting available ...
OK. Heres a patch against CVS (pre new pg_dump). This is a complete patch,
so you can throw away the last two...
Bye for now,
Philip
Attachments:
Sorry about that; I didn't check the 'to' address before sending the patch...
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.C.N. 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
Import Notes
Resolved by subject fallback
Do you want this applied?
At 22:39 3/07/00 -0300, The Hermit Hacker wrote:
that will be correct, but its a quick/easy change ... I'll add the code in
tonight so that its something we check for and set in config.h, so as long
as you include that, you'll have that setting available ...OK. Heres a patch against CVS (pre new pg_dump). This is a complete patch,
so you can throw away the last two...Bye for now,
Philip
[ Attachment, skipping... ]
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.C.N. 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 0500 83 82 82 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp5.ai.mit.edu:11371 |/
--
Bruce Momjian | http://www.op.net/~candle
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026