Apr 2020

3 commits
Stop requiring an explicit return from perl subroutines
14 Apr 2020Andrew Dunstanmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 98% surewritten from the discussion, no matching patch

The commit removes the RequireFinalReturn severity override while retaining global severity 5, implementing the discussion in #5, #16, and #23. Although #8 removes the same configuration lines, its simultaneous switch to severity 3 would keep that policy active, so it does not implement the committed behavior.

Use perl's $/ more idiomatically
13 Apr 2020Andrew Dunstanmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #81 of 1 reviewer saw the final version

All four committed hunks exactly match the $/ cleanups in src/tools/msvc/Install.pm, src/tools/msvc/Project.pm, and src/tools/win32tzlist.pl from #8. Other magic-variable changes and policy enforcement were omitted following Noah Misch's review #17.

  • Noah Mischsaw the final versionLLM analysis, 100% sureNoah evaluated all four $/ hunks as shorter and more robust and recommended landing them without enforcing the corresponding policy #17.
Use perl warnings pragma consistently
13 Apr 2020Andrew Dunstanmaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #81 of 1 reviewer saw the final version

The commit selects the warnings-pragma component of the four-patch submission #8, preserving its source-file changes. Its perlcriticrc hunk instead promotes RequireUseWarnings to severity 5, exactly as Noah Misch proposed #17, without adopting the broader severity-3 transition.

  • Noah Mischsaw the final versionLLM analysis, 100% sureNoah reviewed the warnings additions and supplied the severity-5 policy configuration used in the commit #17.

Credits across 3 commits

Author
Andrew DunstanLLM2
Committer
Andrew Dunstan3

N LLM means N of the credits come from LLM analysis, not from commit trailers.