Vintage unused variables in pg_dump.c
Started by Daniel Gustafssonalmost 6 years ago2 messageshackers
Unless I'm missing something, the g_comment_start and g_comment_end variables
in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
cycle) and can probably be safely removed by now. The attached passes make
check.
cheers ./daniel
Attachments:
pg_dump_unused_vars.patchapplication/octet-stream; name=pg_dump_unused_vars.patch; x-unix-mode=0644Download+0-13
Re: Vintage unused variables in pg_dump.c
Daniel Gustafsson <daniel@yesql.se> writes:
Unless I'm missing something, the g_comment_start and g_comment_end variables
in pg_dump.c seems to have been unused since 30ab5bd43d8f2082659191 (in the 7.2
cycle) and can probably be safely removed by now.
Indeed. (Well, I didn't verify your statement about when they were
last used, but they're clearly dead now.) Pushed.
regards, tom lane