Sep 2021

1 commit
pgcrypto: Check for error return of px_cipher_decrypt()
25 Sep 2021Daniel GustafssonREL_13_STABLE13.5REL_12_STABLE12.9REL_11_STABLE11.14REL_10_STABLE10.19
LLM analysis, 100% surelanded as postedfrom patchset #511 of 1 reviewer saw the final version

The contrib/pgcrypto/px.c changes exactly reproduce #51 modulo shifted context; #67 explicitly identifies this work as backporting the previously landed error check, and #71 announces the push.

  • Daniel Gustafssonsaw the final versiontrailerDaniel tested the patch with and without the legacy provider in #52 and later committed this backport after the discussion in #67.

Aug 2021

2 commits
Add alternative output for OpenSSL 3 without legacy loaded
10 Aug 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.0REL_13_STABLE13.5+3 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #561 of 1 reviewer saw the final version

This takes the alternative-output and documentation member of #56 unchanged: five contrib/pgcrypto/expected files and doc/src/sgml/pgcrypto.sgml; the padding member landed separately.

  • Michael Paquiersaw the final versiontrailerMichael endorsed the complete submission in #57, and Daniel acknowledged his review in #58.
Disable OpenSSL EVP digest padding in pgcrypto
10 Aug 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.0REL_13_STABLE13.5+3 more
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #562 of 2 reviewers saw the final version

This takes the padding member of #56 unchanged, adding the two checked EVP_CIPHER_CTX_set_padding(..., 0) calls in contrib/pgcrypto/openssl.c; the alternative-output member landed separately.

  • Peter Eisentrautsaw the final versiontrailerPeter investigated the existing padding proposal and endorsed its unchanged core as sound and low-risk in #55, which became the padding member of #56.
  • Michael Paquiersaw the final versiontrailerMichael requested padding-call error checks in #35, reported compatibility testing in #50, and endorsed the final submission in #57.

Mar 2021

1 commit
pgcrypto: Check for error return of px_cipher_decrypt()
23 Mar 2021Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #511 of 1 reviewer saw the final version

The commit exactly matches #51: declare err, capture px_cipher_decrypt()'s return value, and return failures before unpadding; Peter announced the landing in #54.

  • Daniel Gustafssonsaw the final versiontrailerDaniel confirmed in #52 that the patch removed the erroneous results without the legacy provider and preserved passing tests with it enabled.

Jul 2020

1 commit
Define OPENSSL_API_COMPAT
19 Jul 2020Peter Eisentrautmaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1REL_13_STABLE13.12+2 moreAlso in: Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~ (modified before commit)
LLM analysis, 100% suremodified before commitlight changesfrom patchset #290 of 1 reviewer saw the final version

The commit follows #29, correcting OPENSSL_API_COMPAT from 10001 to 0x10001000L, adapting the MSVC extraction regex, and adding the minimum-version comment requested in #30; #31 confirms these edits.

  • Daniel Gustafssonsaw an earlier versiontrailerDaniel discussed the initial definition's placement in #23, before it moved into configure and gained the MSVC configuration implementation in #29.

Jun 2020

2 commits
OpenSSL 3.0.0 compatibility in tests
5 Jun 2020Peter Eisentrautmaster13beta2REL_19_STABLE13beta2REL_18_STABLE13beta2REL_17_STABLE13beta2REL_16_STABLE13beta2REL_15_STABLE13beta2REL_14_STABLE13beta2REL_13_STABLE13beta2
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit takes the test-data member of #1 unchanged, including the AES256 Makefile command and regenerated server-password.key, while omitting the exploratory API replacements; #20 confirms that selection.

  • Andrew Dunstansaw the final versionLLM analysis, 99% sureAndrew explicitly supported applying the AES256 test-key change immediately in #7, noting matching cipher use in his callback tests.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Make ssl certificate for ssl_passphrase_callback test via Makefile
1 Jun 2020Andrew Dunstanmaster13beta2REL_19_STABLE13beta2REL_18_STABLE13beta2REL_17_STABLE13beta2REL_16_STABLE13beta2REL_15_STABLE13beta2REL_14_STABLE13beta2REL_13_STABLE13beta2
LLM analysis, 100% suremodified before commitlight changesfrom patchset #142 of 2 reviewers saw the final version

The Makefile additions match #14 exactly, with an additional comment-only edit in t/001_testfunc.pl replacing the duplicate certificate recipe with a Makefile pointer as requested in #15.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom approved the Makefile approach and requested removal of the duplicate test-script recipe in #15, which the commit implements.
  • Peter Eisentrautsaw the final versionLLM analysis, 86% surePeter identified the missing Makefile regeneration rule in #9, prompting the implemented change; his later attachment review in #16 occurred after this commit.

Credits across 7 commits

Author
Daniel Gustafsson2 LLM3
Peter Eisentraut2 LLM3
Andrew DunstanLLM1
Reviewer
Daniel Gustafsson3
Michael Paquiercommitter3
Peter Eisentrautcommitter2
Committer
Daniel Gustafsson3
Peter Eisentraut3
Andrew Dunstan1
Michael Paquier1

N LLM means N of the credits come from LLM analysis, not from commit trailers.