Update InsertPgAttributeTuple comment to match new signature

Started by Daniel Gustafssonalmost 6 years ago3 messageshackers
Jump to latest
#1Daniel Gustafsson
daniel@yesql.se

The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
reality as attoptions isn't always initialized to NULL. The attached removes
mention of attoptions, and updates the list of always-NULL attributes to match
what the code does (the git history didn't provide rationale for why they were
omitted so it seemed like an oversight).

cheers ./daniel

Attachments:

insertpgattributetuple_comment.patchapplication/octet-stream; name=insertpgattributetuple_comment.patch; x-unix-mode=0644Download+2-3
#2Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#1)
Re: Update InsertPgAttributeTuple comment to match new signature

On Mon, Jun 22, 2020 at 04:27:18PM +0200, Daniel Gustafsson wrote:

The comment for InsertPgAttributeTuple no longer, since 911e702077037996, match
reality as attoptions isn't always initialized to NULL. The attached removes
mention of attoptions, and updates the list of always-NULL attributes to match
what the code does (the git history didn't provide rationale for why they were
omitted so it seemed like an oversight).

Looks right to me, good catch. I'll apply that tomorrow my time
except if there are any objections in-between.
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Update InsertPgAttributeTuple comment to match new signature

On Tue, Jun 23, 2020 at 02:31:05PM +0900, Michael Paquier wrote:

Looks right to me, good catch. I'll apply that tomorrow my time
except if there are any objections in-between.

And done.
--
Michael