Type formatting and oidvectortypes

Started by Peter Eisentrautover 25 years ago2 messages
#1Peter Eisentraut
peter_e@gmx.net

The oidvectortypes function, mostly used by psql \df, formats types
separated by spaces:

varchar float8 timetz int4

which would look a little odd when canonical type names are used:

character varying double precision time with time zone integer

I suggest that we separate the types by <comma><space>, which also looks a
little more like how they are invoked in a function call.

Concerns?

--
Peter Eisentraut Sernanders v�g 10:115
peter_e@gmx.net 75262 Uppsala
http://yi.org/peter-e/ Sweden

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: Type formatting and oidvectortypes

Peter Eisentraut <peter_e@gmx.net> writes:

I suggest that we separate the types by <comma><space>, which also looks a
little more like how they are invoked in a function call.

No strong objections here. I'm not very concerned about backwards
compatibility because there probably aren't many apps besides psql
that use oidvectortypes at all. (Heck, we renamed the function in
7.0, and I don't recall many complaints...)

regards, tom lane