Quick doc patch

Started by Guillaume Lelargealmost 6 years ago5 messageshackers
Jump to latest
#1Guillaume Lelarge
guillaume@lelarge.info

Hi,

Here is a quick issue I found on the BRIN documentation. I'm not a 100%
sure I'm right but it looks like a failed copy/paste from the GIN
documentation.

Cheers.

--
Guillaume.

Attachments:

brin.patchtext/x-patch; charset=US-ASCII; name=brin.patchDownload+1-1
#2Daniel Gustafsson
daniel@yesql.se
In reply to: Guillaume Lelarge (#1)
Re: Quick doc patch

On 7 Jul 2020, at 09:17, Guillaume Lelarge <guillaume@lelarge.info> wrote:

Here is a quick issue I found on the BRIN documentation. I'm not a 100% sure I'm right but it looks like a failed copy/paste from the GIN documentation.

I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
paragraph for both GIN and BRIN. LGTM. Adding Alexander who committed in on
cc.

cheers ./daniel

#3Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#2)
Re: Quick doc patch

On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:

I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
paragraph for both GIN and BRIN. LGTM. Adding Alexander who committed in on
cc.

+1.
--
Michael
#4Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#3)
Re: Quick doc patch

On Tue, Jul 07, 2020 at 06:36:10PM +0900, Michael Paquier wrote:

On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:

I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
paragraph for both GIN and BRIN. LGTM. Adding Alexander who committed in on
cc.

+1.

Alexander does not seem to be around, so I have just applied the fix.
There were more inconsistencies in gin.sgml and spgist.sgml missed in
14903f2, making the docs of GIN/SP-GiST less in line with the BRIN
equivalent, so I have fixed both while on it.
--
Michael

#5Alexander Korotkov
aekorotkov@gmail.com
In reply to: Michael Paquier (#4)
Re: Quick doc patch

Hi!

On Wed, Jul 8, 2020 at 4:43 AM Michael Paquier <michael@paquier.xyz> wrote:

On Tue, Jul 07, 2020 at 06:36:10PM +0900, Michael Paquier wrote:

On Tue, Jul 07, 2020 at 09:58:59AM +0200, Daniel Gustafsson wrote:

I agree, it looks like a copy-pasteo in 15cb2bd2700 which introduced the
paragraph for both GIN and BRIN. LGTM. Adding Alexander who committed in on
cc.

+1.

Alexander does not seem to be around, so I have just applied the fix.
There were more inconsistencies in gin.sgml and spgist.sgml missed in
14903f2, making the docs of GIN/SP-GiST less in line with the BRIN
equivalent, so I have fixed both while on it.

I just read this thread.
Thank you for fixing this!

------
Regards,
Alexander Korotkov