describe-config issue

Started by vignesh Cabout 6 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t42887
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 02:24 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t42887_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t42887_1 && git checkout t42887_1

Patchset v1 (message #1) is on t42887_1

Jump to latest
#1vignesh C
vignesh21@gmail.com

Hi,

Postgres's describe-config option prints reset_val for int & real
configuration parameters which is not useful as it is not updated.
Printing boot_val is better in this case. reset_val is updated with
boot_val while the server is getting started but in case of postgres
--describe-config this value is not updated. I felt printing boot_val
is more appropriate in this case. Attached patch for the same.
Thoughts?

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachments:

t42887_1
0001-describe-config-issue.patchtext/x-patch; charset=US-ASCII; name=0001-describe-config-issue.patchDownload+2-3
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: vignesh C (#1)
Re: describe-config issue

vignesh C <vignesh21@gmail.com> writes:

Postgres's describe-config option prints reset_val for int & real
configuration parameters which is not useful as it is not updated.

Uh, what?

Printing boot_val is better in this case.

Please defend that claim. Otherwise this seems like a pretty
random change.

regards, tom lane

#3vignesh C
vignesh21@gmail.com
In reply to: Tom Lane (#2)
Re: describe-config issue

On Wed, Sep 2, 2020 at 8:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

Please defend that claim. Otherwise this seems like a pretty
random change.

I had seen that there is discrepancy in postgres --describe-config & the
value displayed from pg_settings like in the below case:
postgres=# select name,min_val, max_val, boot_val,reset_val from
pg_settings where name = 'checkpoint_timeout';
name | min_val | max_val | *boot_val | reset_val*
--------------------+---------+---------+----------+-----------
checkpoint_timeout | 30 | 86400 | *300 | 300*
(1 row)

[vignesh@localhost bin]$ ./postgres --describe-config | grep
checkpoint_timeout
checkpoint_timeout sighup Write-Ahead Log / Checkpoints INTEGER *0 *30
86400 Sets the maximum time between automatic WAL checkpoints.

In the case of pg_settings we display 300 for boot_val/reset_val whereas in
the case of describe-config we display 0, shouldn't it be 300 here?
Thoughts?

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com