[PATCH] Comments related to " buffer descriptors“ cache line size"

Started by Kelly Minover 5 years ago3 messageshackers
Jump to latest
#1Kelly Min
myzhmin@gmail.com

hello, hackers.

I found a comment error in buffer descriptors comment. The cache line size
is 64 bytes, not 64 bits

Attachments:

buffer-descriptor.patchapplication/octet-stream; name=buffer-descriptor.patchDownload+1-1
#2Bruce Momjian
bruce@momjian.us
In reply to: Kelly Min (#1)
Re: [PATCH] Comments related to " buffer descriptors“ cache line size"

On Fri, Sep 4, 2020 at 11:31:55PM +0800, Kelly Min wrote:

hello, hackers.

I found a comment error in buffer descriptors comment. The cache line size is
64 bytes, not 64 bits

Thanks, fix applied to all active branches.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com

The usefulness of a cup is in its emptiness, Bruce Lee

#3Thomas Munro
thomas.munro@gmail.com
In reply to: Bruce Momjian (#2)
Re: [PATCH] Comments related to " buffer descriptors“ cache line size"

On Sat, Sep 5, 2020 at 5:28 AM Bruce Momjian <bruce@momjian.us> wrote:

On Fri, Sep 4, 2020 at 11:31:55PM +0800, Kelly Min wrote:

I found a comment error in buffer descriptors comment. The cache line size is
64 bytes, not 64 bits

Thanks, fix applied to all active branches.

I find it a bit strange that our PG_CACHE_LINE_SIZE macro is defined
to be 128. Whether that exaggerated number (unless you're on POWER,
where it's true) makes sense depends on what your goals are, as this
usage of hard-coded 64 shows...