Jul - Aug 2021

6 commits
Remove some special cases from MSVC build scripts
9 Aug 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #300 of 4 reviewers saw the final version

Matches the complete remaining patch in #30, with two libpq include paths changed to forward slashes and a helper comment reworded. The parsing and source-discovery logic is unchanged.

  • Andres Freundsaw an earlier versionLLM analysis, 99% sureIn #2, he questioned the special cases and requested a separate internal file-addition function; the source-discovery implementation subsequently underwent moderate changes.
  • Alvaro Herrerasaw an earlier versionLLM analysis, 99% sureHe simplified extension discovery in #4 and challenged the remaining libpq_pipeline exceptions in #21, before the helper and assignment parsing were revised in #30.
  • Michael Paquiersaw an earlier versionLLM analysis, 99% sureHe examined generated dependency changes in #6, tested the patch in #8, and questioned additional-source parsing in #11, before the final helper rework.
  • Dagfinn Ilmari Mannsåkersaw an earlier versionLLM analysis, 100% sureHis Perl review in #19 corrected method-call syntax and moved an invariant check outside a loop, but the dependency-discovery logic changed further in #30.
Adjust MSVC build scripts to parse Makefiles for defines
29 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #290 of 1 reviewer saw the final version

Commits the defines-parsing component of the four-patch series in #29, including the ltree Makefile/header adjustment. Its only additional edits explicitly initialize @projects and clarify one comment.

  • Tom Lanesaw an earlier versiontrailerIn #20, he reviewed the defines component and proposed moving LOWER_NODE into ltree.h; that local restructuring followed his review, with no subsequent review of #29 shown.
Don't duplicate references and libraries in MSVC scripts
28 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #293 of 3 reviewers saw the final version

Commits only the reference/library deduplication component of #29; its added and removed lines in src/tools/msvc/Project.pm match that component exactly.

  • Álvaro Herrerasaw the final versiontrailerHe questioned boolean grep usage and suggested deduplicating at the end in #21 and #24, while the reviewed implementation remained unchanged through commitment.
  • Andrew Dunstansaw the final versiontrailerIn #22, he defended the boolean grep expression as a widely used idiom, and that expression remained in the committed component.
  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #23, he confirmed boolean grep was idiomatic and explained why List::Util::any was unsuitable for supported Perl versions; the deduplication code then landed unchanged.
Make the includes field an array in MSVC build scripts
28 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #293 of 3 reviewers saw the final version

Commits the includes-array component of #29, covering MSBuildProject.pm, Mkvcbuild.pm and Project.pm. Its added and removed lines match the attachment exactly.

  • Álvaro Herrerasaw the final versiontrailerHe proposed using join in #14 and shortening the include-copy loop in #21, after which only equivalent Perl-expression changes followed.
  • Andrew Dunstansaw the final versiontrailerHe supplied the adopted join expression in #15 and advised against map for side effects in #22, with only light changes afterward.
  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #23, he supplied the postfix for-loop spelling incorporated into #29 and retained in the commit.
Use the AddFile function consistently in MSVC build scripts
28 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #181 of 1 reviewer saw the final version

Commits the AddFile cleanup component of #18, changing its five explicit AddFile($self, ...) calls to method syntax. #29 confirms this component was pushed with that adjustment.

  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerIn #19, he requested method-call syntax for AddFile, which was the only code adjustment made to this component before commitment.
Remove seemingly unneeded include directory in MSVC scripts
28 Jul 2021David Rowleymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #182 of 2 reviewers saw the final version

Commits only the dblink include-directory component of #18; the single replacement of contrib_extraincludes in src/tools/msvc/Mkvcbuild.pm is identical.

  • Michael Paquiersaw the final versionLLM analysis, 91% sureIn #8, he tested the earlier combined patch and explicitly examined dblink losing src/backend from its includes; that same removal later landed unchanged.
  • Tom Lanesaw the final versionLLM analysis, 100% sureIn #20, he investigated the historical include-path addition, agreed it appeared unnecessary, and recommended committing the removal.

Credits across 6 commits

Author
David Rowley5 LLM6
Reviewer
Dagfinn Ilmari Mannsåker3
Alvaro Herrera2
Andrew Dunstan2
Tom Lane1
Committer
David Rowley6

N LLM means N of the credits come from LLM analysis, not from commit trailers.