obsolete comment from WITH OIDS days

Started by Amit Langoteabout 5 years ago2 messages
#1Amit Langote
amitlangote09@gmail.com
1 attachment(s)

Hi,

I noticed a couple of comments that were obsoleted by commit
578b229718 which forgot to remove them. Attached fixes that.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachments:

fix-obsolete-comments.patchapplication/octet-stream; name=fix-obsolete-comments.patchDownload
diff --git a/contrib/file_fdw/file_fdw.c b/contrib/file_fdw/file_fdw.c
index 994b90d..9863e32 100644
--- a/contrib/file_fdw/file_fdw.c
+++ b/contrib/file_fdw/file_fdw.c
@@ -724,9 +724,6 @@ fileIterateForeignScan(ForeignScanState *node)
 	 *
 	 * We can pass ExprContext = NULL because we read all columns from the
 	 * file, so no need to evaluate default expressions.
-	 *
-	 * We can also pass tupleOid = NULL because we don't allow oids for
-	 * foreign tables.
 	 */
 	ExecClearTuple(slot);
 	found = NextCopyFrom(festate->cstate, NULL,
diff --git a/src/backend/commands/copyfromparse.c b/src/backend/commands/copyfromparse.c
index b7a37bc..34ed3cf 100644
--- a/src/backend/commands/copyfromparse.c
+++ b/src/backend/commands/copyfromparse.c
@@ -496,7 +496,6 @@ NextCopyFromRawFields(CopyFromState cstate, char ***fields, int *nfields)
  *
  * 'values' and 'nulls' arrays must be the same length as columns of the
  * relation passed to BeginCopyFrom. This function fills the arrays.
- * Oid of the tuple is returned with 'tupleOid' separately.
  */
 bool
 NextCopyFrom(CopyFromState cstate, ExprContext *econtext,
#2Heikki Linnakangas
hlinnaka@iki.fi
In reply to: Amit Langote (#1)
Re: obsolete comment from WITH OIDS days

On 30/11/2020 10:21, Amit Langote wrote:

I noticed a couple of comments that were obsoleted by commit
578b229718 which forgot to remove them. Attached fixes that.

Applied, thanks!

- Heikki