[PATCH] Cross-reference comments on signal handling logic
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t43550psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 05:50 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t43550_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t43550_1 && git checkout t43550_1Patchset v1 (message #1) is on t43550_1
Hi all
The attached comments-only patch expands the signal handling section in
miscadmin.h a bit so that it mentions ProcSignal, deferred signal handling
during blocking calls, etc. It adds cross-refs between major signal
handling routines and the miscadmin comment to help readers track the
various scattered but inter-related code.
I hope this helps some new developers in future.
On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig.ringer@enterprisedb.com> wrote:
<v1-0001-Comments-and-cross-references-for-signal-handling.patch>
In src/backend/postmaster/interrupt.c:
+ * These handlers are NOT used by normal user backends as they do not support
vs.
+ * Most backends use this handler.
These two comments seem to contradict. If interrupt.c contains handlers that normal user backends to not use, then how can it be that most backends use one of the handlers in the file?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 1 Mar 2021, at 19:22, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
On Jan 17, 2021, at 11:51 PM, Craig Ringer <craig.ringer@enterprisedb.com> wrote:
<v1-0001-Comments-and-cross-references-for-signal-handling.patch>
In src/backend/postmaster/interrupt.c:
+ * These handlers are NOT used by normal user backends as they do not support
vs.
+ * Most backends use this handler.
These two comments seem to contradict. If interrupt.c contains handlers that normal user backends to not use, then how can it be that most backends use one of the handlers in the file?
I'm closing this as Returned with Feedback as it there has been no response to
the review comment during two commitfests. Please reopen in a future
commitfest if you still would like to pursue this patch.
--
Daniel Gustafsson https://vmware.com/