Apr 2021

1 commit
Move some client-specific routines from SSLServer to PostgresNode
1 Apr 2021Michael Paquiermaster14beta1REL_19_STABLE14beta1REL_18_STABLE14beta1REL_17_STABLE14beta1REL_16_STABLE14beta1REL_15_STABLE14beta1REL_14_STABLE14beta1
LLM analysis, 100% surelanded as postedfrom patchset #133 of 3 reviewers saw the final version

The diff in #13 matches 0d1a33438d exactly after excluding Git index lines, which differ only in object-ID abbreviation length. All four files match, including PostgresNode.pm's new connection helpers and both SSL test scripts' converted call sites.

  • Andrew Dunstansaw the final versiontrailerAndrew explained the OO/exporter problems with #2 in #5 and endorsed the cleanup #7 in #8, after which only light revisions followed.
  • Daniel Gustafssonsaw the final versiontrailerDaniel reviewed #7 in #10, recommending simpler connection-string interpolation, which was incorporated into #13 alongside other light changes.
  • Álvaro Herrerasaw the final versiontrailerÁlvaro challenged the module inheritance in #3 and reviewed #7 in #9, identifying POD wording and argument-order problems and unnecessary returns that were corrected in #13.

Credits across 1 commit

Author
Michael Paquier1
Reviewer
Alvaro Herrera1
Andrew Dunstan1
Daniel Gustafsson1
Committer
Michael Paquier1