Buildfarm failure in crake

Started by vignesh Cabout 5 years ago2 messageshackers
Jump to latest
#1vignesh C
vignesh21@gmail.com

Hi,

I noticed there is buildfarm failure in crake, it fails with the
following error:
Mar 02 21:22:56 ./src/test/recovery/t/001_stream_rep.pl: Variable
declared in conditional statement at line 88, column 2. Declare
variables outside of the condition.
([Variables::ProhibitConditionalDeclarations] Severity: 5)

I felt the variable declaration and the assignment need to be split as
it involves conditional statements. I have attached a patch which will
help in fixing the problem.
Thoughts?

Regards,
Vignesh

Attachments:

buildfarm_failure.patchtext/x-patch; charset=US-ASCII; name=buildfarm_failure.patchDownload+2-1
#2Michael Paquier
michael@paquier.xyz
In reply to: vignesh C (#1)
Re: Buildfarm failure in crake

On Wed, Mar 03, 2021 at 08:46:41AM +0530, vignesh C wrote:

I noticed there is buildfarm failure in crake, it fails with the
following error:
Mar 02 21:22:56 ./src/test/recovery/t/001_stream_rep.pl: Variable
declared in conditional statement at line 88, column 2. Declare
variables outside of the condition.
([Variables::ProhibitConditionalDeclarations] Severity: 5)

I felt the variable declaration and the assignment need to be split as
it involves conditional statements. I have attached a patch which will
help in fixing the problem.
Thoughts?

Tom has fixed that with d422a2a.
--
Michael