Winflex docs and distro

Started by Magnus Haganderover 4 years ago5 messages
#1Magnus Hagander
magnus@hagander.net

Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:

+       The obsolete "winflex" binaries distributed on the PostgreSQL FTP site
+       and referenced in older documentation will fail with "flex: fatal
+       internal error, exec failed" on 64-bit Windows hosts. Use flex from
+       msys instead.

At this point. I suggest we simply stop distributing winflex on our
download site, and just remove this note from the documentation. (This
is just a note, the general documentation still says get flex from
msys, separately).

Surely a binary that doesn't work on a 64-bit system is not of help to
anybody these days.. And "older documentation" now refers to 9.2 which
was EOL in 2017.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

#2Daniel Gustafsson
daniel@yesql.se
In reply to: Magnus Hagander (#1)
Re: Winflex docs and distro

On 17 May 2021, at 10:17, Magnus Hagander <magnus@hagander.net> wrote:

Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:

+ The obsolete "winflex" binaries distributed on the PostgreSQL FTP site

Which was slightly updated in 0a9ae44288d.

At this point. I suggest we simply stop distributing winflex on our
download site, and just remove this note from the documentation.

Sounds reasonable, are there (easily retrieved) logs/tracking for when it was
accessed by anyone last?

--
Daniel Gustafsson https://vmware.com/

#3Magnus Hagander
magnus@hagander.net
In reply to: Daniel Gustafsson (#2)
Re: Winflex docs and distro

On Mon, May 17, 2021 at 11:11 AM Daniel Gustafsson <daniel@yesql.se> wrote:

On 17 May 2021, at 10:17, Magnus Hagander <magnus@hagander.net> wrote:

Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:

+ The obsolete "winflex" binaries distributed on the PostgreSQL FTP site

Which was slightly updated in 0a9ae44288d.

It's been touched a couple of times, but not in any material fashion.

At this point. I suggest we simply stop distributing winflex on our
download site, and just remove this note from the documentation.

Sounds reasonable, are there (easily retrieved) logs/tracking for when it was
accessed by anyone last?

Not really. We don't keep logs going very far back. I can see it being
accessed a handful of time in the past 14 days. But AFAICT from the
limited information we have it's all bots.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Magnus Hagander (#3)
Re: Winflex docs and distro

On 5/17/21 5:51 AM, Magnus Hagander wrote:

On Mon, May 17, 2021 at 11:11 AM Daniel Gustafsson <daniel@yesql.se> wrote:

On 17 May 2021, at 10:17, Magnus Hagander <magnus@hagander.net> wrote:
Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:

+ The obsolete "winflex" binaries distributed on the PostgreSQL FTP site

Which was slightly updated in 0a9ae44288d.

It's been touched a couple of times, but not in any material fashion.

At this point. I suggest we simply stop distributing winflex on our
download site, and just remove this note from the documentation.

Sounds reasonable, are there (easily retrieved) logs/tracking for when it was
accessed by anyone last?

Not really. We don't keep logs going very far back. I can see it being
accessed a handful of time in the past 14 days. But AFAICT from the
limited information we have it's all bots.

+1 for removing the binary and the reference.

These days my setup for MSVC doesn't use msys: it's basically this PS1
fragment (which assumes chocolatey is installed):

    $utils = 'StrawberryPerl', 'git', 'winflexbison', 'diffutils', 'vim'
    choco install -y --no-progress --limit-output @utils
    $cbin = "c:\ProgramData\chocolatey\bin"
    Rename-Item -Path $cbin\win_bison.exe -NewName bison.exe
    Rename-Item -Path $cbin\win_flex.exe -NewName flex.exe

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

#5Magnus Hagander
magnus@hagander.net
In reply to: Andrew Dunstan (#4)
Re: Winflex docs and distro

On Mon, May 17, 2021 at 2:55 PM Andrew Dunstan <andrew@dunslane.net> wrote:

On 5/17/21 5:51 AM, Magnus Hagander wrote:

On Mon, May 17, 2021 at 11:11 AM Daniel Gustafsson <daniel@yesql.se> wrote:

On 17 May 2021, at 10:17, Magnus Hagander <magnus@hagander.net> wrote:
Since PostgreSQL 9.3, in commit a266f7dd93b, we've added the text:

+ The obsolete "winflex" binaries distributed on the PostgreSQL FTP site

Which was slightly updated in 0a9ae44288d.

It's been touched a couple of times, but not in any material fashion.

At this point. I suggest we simply stop distributing winflex on our
download site, and just remove this note from the documentation.

Sounds reasonable, are there (easily retrieved) logs/tracking for when it was
accessed by anyone last?

Not really. We don't keep logs going very far back. I can see it being
accessed a handful of time in the past 14 days. But AFAICT from the
limited information we have it's all bots.

+1 for removing the binary and the reference.

I think we've collected enough +1's, so I'll go ahead and do it.

These days my setup for MSVC doesn't use msys: it's basically this PS1
fragment (which assumes chocolatey is installed):

$utils = 'StrawberryPerl', 'git', 'winflexbison', 'diffutils', 'vim'
choco install -y --no-progress --limit-output @utils
$cbin = "c:\ProgramData\chocolatey\bin"
Rename-Item -Path $cbin\win_bison.exe -NewName bison.exe
Rename-Item -Path $cbin\win_flex.exe -NewName flex.exe

Perhaps it is, as a separate thing, worth including that in the docs
soemwhere? Or maybe as a script int he sourcetree that is referenced
frot he docs?

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/