Nov 2021

3 commits
Use test-specific temp path for keys during SSL test
30 Nov 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 1 reviewer saw the final version

c113d8ad50 matches the complete third patch in #9, moving temporary keys into tmp_check in 001_ssltests.pl and 002_scram.pl and removing obsolete cleanup and ignore rules.

  • Tom Lanesaw the final versiontrailerTom identified the existing suites' temporary-key problem in #7 and declared the resulting series good to go in #10.
Add TAP tests for contrib/sslinfo
30 Nov 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #91 of 3 reviewers saw the final version

ae81776a23 implements the second patch of #9, incorporating the README and comment corrections from #10. The remaining difference is removal of a trailing blank line in conf/client_ext.config.

  • Tom Lanesaw the final versiontrailerTom checked coverage and requested missing tests, documentation, and temporary-file fixes in #7, then supplied final editorial corrections and approval in #10.
  • Andrew Dunstanno review foundtrailerAndrew's review in #3 concerns database iteration in the separately committed SSLServer.pm helper, with no demonstrated review of the sslinfo tests themselves.
  • Dagfinn Ilmari Mannsåkerno review foundtrailerIlmari's review in #2 concerns the separately committed helper's extension argument and CASCADE behavior, with no demonstrated review of the sslinfo tests themselves.
Extend configure_test_server_for_ssl to add extensions
30 Nov 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #91 of 3 reviewers saw the final version

879fc1a579 matches the complete first patch in #9, including named password parameters, database iteration, and extension creation through an array reference with CASCADE.

  • Tom Lanesaw the final versiontrailerTom requested the password-encryption wording correction in #7 and approved the revised series in #10.
  • Andrew Dunstansaw an earlier versiontrailerAndrew requested database iteration in #3, after which the helper gained loops, array-reference handling, and CASCADE in #4, with no later review shown.
  • Dagfinn Ilmari Mannsåkersaw an earlier versiontrailerIlmari requested an array reference and CASCADE in #2, which changed the helper's interface and behavior in #4, with no later review shown.

Credits across 3 commits

Author
Daniel GustafssonLLM3
Reviewer
Tom Lane3
Andrew Dunstan2
Dagfinn Ilmari Mannsåker2
Committer
Daniel Gustafsson3

N LLM means N of the credits come from LLM analysis, not from commit trailers.