tab-complete for CREATE TYPE ... SUBSCRIPT

Started by tanghy.fnst@fujitsu.comover 4 years ago4 messages

over 4 years ago

1 attachment(s)

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Regards,
Tang

Attachments:

0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchapplication/octet-stream; name=0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchDownload

From e072bd6aa9e519a55edec102bf9588618bc9f354 Mon Sep 17 00:00:00 2001
From: tanghy <tanghy.fnst@fujitsu.com>
Date: Wed, 2 Jun 2021 18:31:06 +0900
Subject: [PATCH] psql: tab-complete CREATE TYPE ... SUBSCRIPT

New keywords per c7aba7c14e.

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 6598c5369a..97cfa188a5 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2959,7 +2959,7 @@ psql_completion(const char *text, int start, int end)
 	{
 		if (TailMatches("(|*,"))
 			COMPLETE_WITH("INPUT", "OUTPUT", "RECEIVE", "SEND",
-						  "TYPMOD_IN", "TYPMOD_OUT", "ANALYZE",
+						  "TYPMOD_IN", "TYPMOD_OUT", "ANALYZE", "SUBSCRIPT"
 						  "INTERNALLENGTH", "PASSEDBYVALUE", "ALIGNMENT",
 						  "STORAGE", "LIKE", "CATEGORY", "PREFERRED",
 						  "DEFAULT", "ELEMENT", "DELIMITER",
-- 
2.31.1.windows.1

tanghy.fnst@fujitsu.com

over 4 years ago

In reply to: tanghy.fnst@fujitsu.com (#1)

1 attachment(s)

RE: tab-complete for CREATE TYPE ... SUBSCRIPT

On Wednesday, June 2, 2021 6:51 PM, tanghy.fnst@fujitsu.com wrote:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Oops, comma forgot. patch Updated.

Regards,
Tang

Attachments:

V2-0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchapplication/octet-stream; name=V2-0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchDownload

From 903a615b0105e3a85543cc9bb8e60293311ac092 Mon Sep 17 00:00:00 2001
From: tanghy <tanghy.fnst@fujitsu.com>
Date: Wed, 2 Jun 2021 18:31:06 +0900
Subject: [PATCH] psql: tab-complete CREATE TYPE ... SUBSCRIPT

New keywords per c7aba7c14e.

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 6598c5369a..d4188a8031 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2959,7 +2959,7 @@ psql_completion(const char *text, int start, int end)
 	{
 		if (TailMatches("(|*,"))
 			COMPLETE_WITH("INPUT", "OUTPUT", "RECEIVE", "SEND",
-						  "TYPMOD_IN", "TYPMOD_OUT", "ANALYZE",
+						  "TYPMOD_IN", "TYPMOD_OUT", "ANALYZE", "SUBSCRIPT",
 						  "INTERNALLENGTH", "PASSEDBYVALUE", "ALIGNMENT",
 						  "STORAGE", "LIKE", "CATEGORY", "PREFERRED",
 						  "DEFAULT", "ELEMENT", "DELIMITER",
-- 
2.31.1.windows.1

Bharath Rupireddy

bharath.rupireddyforpostgres@gmail.com

over 4 years ago

In reply to: tanghy.fnst@fujitsu.com (#2)

Re: tab-complete for CREATE TYPE ... SUBSCRIPT

On Wed, Jun 2, 2021 at 4:37 PM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:

On Wednesday, June 2, 2021 6:51 PM, tanghy.fnst@fujitsu.com wrote:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Oops, comma forgot. patch Updated.

v2 patch LGTM.

With the patch:
postgres=# create type mytype(
ALIGNMENT DEFAULT INTERNALLENGTH PREFERRED SUBSCRIPT
ANALYZE DELIMITER LIKE RECEIVE TYPMOD_IN
CATEGORY ELEMENT OUTPUT SEND TYPMOD_OUT
COLLATABLE INPUT PASSEDBYVALUE STORAGE

With Regards,
Bharath Rupireddy.

Tom Lane

tgl@sss.pgh.pa.us

over 4 years ago

In reply to: tanghy.fnst@fujitsu.com (#1)

Re: tab-complete for CREATE TYPE ... SUBSCRIPT

"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Huh ... I had no idea anyone had taught tab-complete about the
individual fields of CREATE TYPE. Experimenting with it,
I see that the multirange patch missed this too. Fix pushed.

regards, tom lane