tab-complete for CREATE TYPE ... SUBSCRIPT

Started by tanghy.fnst@fujitsu.comalmost 5 years ago4 messageshackers
Jump to latest
#1tanghy.fnst@fujitsu.com
tanghy.fnst@fujitsu.com

Hi

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Regards,
Tang

Attachments:

0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchapplication/octet-stream; name=0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchDownload+1-2
#2tanghy.fnst@fujitsu.com
tanghy.fnst@fujitsu.com
In reply to: tanghy.fnst@fujitsu.com (#1)
RE: tab-complete for CREATE TYPE ... SUBSCRIPT

On Wednesday, June 2, 2021 6:51 PM, tanghy.fnst@fujitsu.com wrote:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Oops, comma forgot. patch Updated.

Regards,
Tang

Attachments:

V2-0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchapplication/octet-stream; name=V2-0001-psql-tab-complete-CREATE-TYPE-.-SUBSCRIPT.patchDownload+1-2
#3Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com
In reply to: tanghy.fnst@fujitsu.com (#2)
Re: tab-complete for CREATE TYPE ... SUBSCRIPT

On Wed, Jun 2, 2021 at 4:37 PM tanghy.fnst@fujitsu.com
<tanghy.fnst@fujitsu.com> wrote:

On Wednesday, June 2, 2021 6:51 PM, tanghy.fnst@fujitsu.com wrote:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Oops, comma forgot. patch Updated.

v2 patch LGTM.

With the patch:
postgres=# create type mytype(
ALIGNMENT DEFAULT INTERNALLENGTH PREFERRED SUBSCRIPT
ANALYZE DELIMITER LIKE RECEIVE TYPMOD_IN
CATEGORY ELEMENT OUTPUT SEND TYPMOD_OUT
COLLATABLE INPUT PASSEDBYVALUE STORAGE

With Regards,
Bharath Rupireddy.

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: tanghy.fnst@fujitsu.com (#1)
Re: tab-complete for CREATE TYPE ... SUBSCRIPT

"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:

Attached a patch to support tab completion for CREATE TYPE ... SUBSCRIPT introduced at c7aba7c14e.

Huh ... I had no idea anyone had taught tab-complete about the
individual fields of CREATE TYPE. Experimenting with it,
I see that the multirange patch missed this too. Fix pushed.

regards, tom lane