improve installation short version
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t44318psql -h localhost -U postgresBuilt from patchset v5 (message #5), July 27, 2026 at 04:57 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t44318_5 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t44318_5 && git checkout t44318_5Patchset v5 (message #5) is on t44318_5
I just had a case where a new user was slightly confused by our
installation "Short Version" instructions. I think the confusion would
be lessened by adding a couple of comments, as in the attached patch.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Attachments:
short-version-comments.patchtext/x-patch; charset=UTF-8; name=short-version-comments.patchDownload+2-0
On Jun 2, 2021, at 1:43 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
<short-version-comments.patch>
It's not the fault of your patch, but the docs seem to be misleading in ways that your comments don't fix. (Or perhaps my Windows knowledge is just too lacking to realize why these instructions are ok?)
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On 6/2/21 4:58 PM, Mark Dilger wrote:
On Jun 2, 2021, at 1:43 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
<short-version-comments.patch>
It's not the fault of your patch, but the docs seem to be misleading in ways that your comments don't fix. (Or perhaps my Windows knowledge is just too lacking to realize why these instructions are ok?)
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
Yes, good point. We should fix that. Yes, "runas" is a sort of su.
There's no adduser either.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Andrew Dunstan <andrew@dunslane.net> writes:
On 6/2/21 4:58 PM, Mark Dilger wrote:
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
Yes, good point. We should fix that. Yes, "runas" is a sort of su.
There's no adduser either.
There's a whole lot of Unix systems that don't spell that command
as "adduser", either. That whole recipe has to be understood as
a guide, not something you can blindly copy-and-paste.
Maybe what we really need is an initial disclaimer saying something
along the lines of "Here's approximately what you need to do; adapt
these commands per local requirements."
And then, perhaps, change the last line to "For more detail, see
the rest of this chapter".
regards, tom lane
On 6/2/21 5:36 PM, Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
On 6/2/21 4:58 PM, Mark Dilger wrote:
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
Yes, good point. We should fix that. Yes, "runas" is a sort of su.
There's no adduser either.There's a whole lot of Unix systems that don't spell that command
as "adduser", either. That whole recipe has to be understood as
a guide, not something you can blindly copy-and-paste.Maybe what we really need is an initial disclaimer saying something
along the lines of "Here's approximately what you need to do; adapt
these commands per local requirements."And then, perhaps, change the last line to "For more detail, see
the rest of this chapter".
Ok, patch attached
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
On 02.06.21 23:27, Andrew Dunstan wrote:
<short-version-comments.patch>
It's not the fault of your patch, but the docs seem to be misleading in ways that your comments don't fix. (Or perhaps my Windows knowledge is just too lacking to realize why these instructions are ok?)
Prior to where your patch makes changes, the docs say, "If you are building PostgreSQL for Microsoft Windows, read this chapter if you intend to build with MinGW or Cygwin". I think going on to tell the users to use `su` is a bit odd. Does that exist in standard MinGW and Cygwin environments? I thought "run as" was the Windows option for this.
Yes, good point. We should fix that. Yes, "runas" is a sort of su.
There's no adduser either.
I think those instructions were written before "sudo" became common.
Maybe we should update them a bit.