Add index OID macro argument to DECLARE_INDEX

Started by Peter Eisentrautalmost 5 years ago3 messageshackers

peter_e@gmx.net

almost 5 years ago

This patch changes places like this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650, on
pg_aggregate using btree(aggfnoid oid_ops));
#define AggregateFnoidIndexId 2650

to this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650,
AggregateFnoidIndexId, on pg_aggregate using btree(aggfnoid oid_ops));

and makes genbki.pl generate the #define's. This makes the handling of
catalog index OIDs consistent with the handling of catalog tables.
Compare with:

CATALOG(pg_aggregate,2600,AggregateRelationId)

John Naylor

john.naylor@enterprisedb.com

almost 5 years ago

In reply to: Peter Eisentraut (#1)

Re: Add index OID macro argument to DECLARE_INDEX

On Mon, Jun 21, 2021 at 3:23 AM Peter Eisentraut <
peter.eisentraut@enterprisedb.com> wrote:

This patch changes places like this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650, on
pg_aggregate using btree(aggfnoid oid_ops));
#define AggregateFnoidIndexId 2650

to this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650,
AggregateFnoidIndexId, on pg_aggregate using btree(aggfnoid oid_ops));

+1, and the patch looks good to me.

--
John Naylor
EDB: http://www.enterprisedb.com

Peter Eisentraut

peter_e@gmx.net

almost 5 years ago

In reply to: John Naylor (#2)

Re: Add index OID macro argument to DECLARE_INDEX

On 21.06.21 13:53, John Naylor wrote:

This patch changes places like this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650, on
pg_aggregate using btree(aggfnoid oid_ops));
#define AggregateFnoidIndexId 2650

to this

DECLARE_UNIQUE_INDEX_PKEY(pg_aggregate_fnoid_index, 2650,
AggregateFnoidIndexId, on pg_aggregate using btree(aggfnoid oid_ops));

+1, and the patch looks good to me.

committed, thanks

Add index OID macro argument to DECLARE_INDEX

Attachments: