Aug 2021

1 commit
Prohibit map and grep in void context
31 Aug 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #14 of 4 reviewers saw the final version

Both committed hunks match #1: the map-to-foreach rewrite in contrib/intarray/bench/create_test.pl and both severity-5 policies in src/tools/perlcheck/perlcriticrc. Daniel confirmed pushing the complete proposal after consensus #13.

  • Michael Paquiersaw the final versiontrailerMichael reported that pgperlcritic passed with the patch #3 and ultimately accepted including the policy changes #11.
  • Andrew Dunstansaw the final versiontrailerAndrew accepted the proposal while recalling earlier resistance to perlcritic enforcement #4, then supported proceeding with the policies #10.
  • Julien Rouhaudsaw the final versiontrailerJulien endorsed the proposal before it was committed #12.
  • Daniel Gustafssonsaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Dagfinn Ilmari Mannsåker1
Reviewer
Andrew Dunstan1
Daniel Gustafssoncommitter1
Julien Rouhaud1
Michael Paquier1
Committer
Daniel Gustafsson1