Jun 2023

1 commit
Fix possible crash in tablesync worker.
15 Jun 2023Amit Kapilamaster16beta2REL_19_STABLE16beta2REL_18_STABLE16beta2REL_17_STABLE16beta2REL_16_STABLE16beta2
LLM analysis, 100% surelanded as postedfrom patchset #2301 of 1 reviewer saw the final version

The tablesync.c diff has the same stable patch ID as #230; the commit message corrects the patch header's attribution of the original regression.

  • Amit Kapilasaw the final versiontrailerAmit reproduced the crash in #227, requested reuse of the existing transaction in #229, and committed the revised fix.

Apr 2023

2 commits
Display 'password_required' option for \dRs+ command.
24 Apr 2023Amit Kapilamaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #2222 of 2 reviewers saw the final version

The describe.c change and subscription regression changes have the same stable patch ID as #222.

  • Amit Kapilasaw the final versiontrailerAmit approved the attached patch in #223 and committed it.
  • Robert Haassaw the final versiontrailerRobert explicitly approved the attached patch in #224.
Restart the apply worker if the 'password_required' option is changed.
20 Apr 2023Amit Kapilamaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #2151 of 1 reviewer saw the final version

The single passwordrequired comparison added to maybe_reread_subscription has the same stable patch ID as #215.

  • Robert Haassaw the final versiontrailerRobert requested removal of the superuser exception in #214 and approved the revised patch in #216.

Mar - Apr 2023

2 commits
Fix possible logical replication crash.
3 Apr 2023Robert Haasmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

Hou supplied the worker.c fix inline in #205, moving CommitTransactionCommand after superuser_arg; Robert committed that fix with an explanatory comment, as confirmed in #210.

  • Alexander Lakhinsaw an earlier versionLLM analysis, 96% sureAlexander supplied the crash reproducer in #208 acknowledged by the commit; under the required no-source fallback, this predates the later tablesync revision #230.
  • Robert Haassaw the final versioncommittercommitted the patch
Add new predefined role pg_create_subscription.
30 Mar 2023Robert Haasmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1873 of 5 reviewers saw the final version

The implementation matches #187; the committed diff adjusts ALTER SUBSCRIPTION documentation links for the newer base and adds the catalog-version bump.

  • Andres Freundsaw the final versionLLM analysis, 96% sureAndres identified authentication, permission and resource-cleanup problems in #91, #120 and #141, then supported the final design in #197.
  • Jeff Davissaw the final versionLLM analysis, 97% sureJeff reviewed connection privileges and the final patch's security dependencies in #114 and #188, and clarified that his remaining ordering concern was not a hard objection in #201.
  • Mark Dilgersaw an earlier versionLLM analysis, 98% sureMark examined creator-versus-run-as privileges in #123 and #130 and accepted proceeding in #135, before further permission fixes and dump support.
  • Stephen Frostsaw the final versionLLM analysis, 94% sureThe commit explicitly credits Stephen as a reviewer; his discussion in #158 addresses broader execution security, without identifying a particular attached patchset he reviewed.
  • Jacob Championsaw an earlier versionLLM analysis, 93% sureJacob identified the missing ambient-authentication protection in #99, helping motivate the password-required redesign in #118.

Jan 2022

2 commits
More cleanup of a2ab9c06ea.
9 Jan 2022Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: pgsql: Respect permissions within logical replication. (written from the discussion, no matching patch)
LLM analysis, 99% surewritten from the discussion, no matching patch0 of 2 reviewers saw the final version

The ACL_SELECT check in worker.c and reduction of 027_nosuperuser.pl from 100 tests to 14 implement requests in #68, #73 and #74, without a matching attachment. The verdict for thread #226163 likewise identifies discussion-derived work without a matching attachment and supplies the initial-sync fix; the commit combines contributions from both threads rather than originating exclusively there.

  • Amit Kapilasaw an earlier versionLLM analysis, 98% sureAmit identified the missing SELECT privilege check in #68 and reiterated it in #71; the required last-patchset fallback places this review before the thread's later revisions.
  • Tom Lanesaw an earlier versionLLM analysis, 98% sureTom justified SELECT checks in #73 and reported excessive test runtime in #74, both driving this cleanup but preceding the final thread patchset.
Respect permissions within logical replication.
8 Jan 2022Jeff Davismaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #671 of 3 reviewers saw the final version

The permission checks, RLS restrictions, documentation and TAP changes have the same stable patch ID as #67.

  • Jeff Davissaw the final versiontrailerJeff identified missing RLS and partition checks in #37, reviewed the revisions, and announced committing with performance measurements in #70.
  • Andrew Dunstansaw an earlier versiontrailerAndrew reviewed ownership races and transaction-boundary behavior in #3, #10 and #65, before substantive RLS and partition fixes.
  • Ronan Dunklausaw an earlier versiontrailerRonan said the initial patch looked good in #2, before ownership-restart, RLS and partition-handling revisions.

Credits across 7 commits

Author
Amit Kapila1
Hou, Zhijie1
Mark Dilger1
Robert HaasLLM1
vignesh C1
Zhijie Hou (Fujitsu)LLM1
Reviewer
Robert Haascommitter3
Amit Kapila2
Andrew Dunstan1
Jeff Davis1
Ronan Dunklau1
Committer
Amit Kapila3
Jeff Davis2
Robert Haas2

N LLM means N of the credits come from LLM analysis, not from commit trailers.