pg_log_backend_memory_contexts - remove unnecessary test case

Started by Bharath Rupireddyover 4 years ago1 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45429
psql -h localhost -U postgres

Built from patchset v1 (message #1), October 06, 2026 at 11:55 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t45429_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t45429_1 && git checkout t45429_1

Patchset v1 (message #1) is on t45429_1

Jump to latest
#1Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com

Hi,

While reviewing another patch [1]/messages/by-id/04596d19-1bb6-4865-391d-4e63c9b3317f@oss.nttdata.com, I found an unnecessary test case of
pg_log_backend_memory_contexts, that is, executing the function after
granting the permission to the role and checking the permissions with
the has_function_privilege. IMO, it's unnecessary as we have the test
cases covering the function execution just above that. With the
removal of these test cases, the regression tests timings can be
improved (a tiniest tiniest tiniest tiniest amount of time though).
Attaching a small patch.

Thoughts?

[1]: /messages/by-id/04596d19-1bb6-4865-391d-4e63c9b3317f@oss.nttdata.com

Regards,
Bharath Rupireddy.

Attachments:

t45429_1
v1-0001-remove-unnecessary-test-case.patchapplication/octet-stream; name=v1-0001-remove-unnecessary-test-case.patchDownload+0-12