Fix CheckIndexCompatible comment
Hello,
I found a old parameter name 'heapRelation' in the comment
of CheckIndexCompatible. This parameter was removed by 5f173040.
Attached is a patch to remove it from the comment.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
Attachments:
fix_CheckIndexCompatible_comment.patchtext/x-diff; name=fix_CheckIndexCompatible_comment.patchDownload+0-1
On 2022/02/04 1:46, Yugo NAGATA wrote:
Hello,
I found a old parameter name 'heapRelation' in the comment
of CheckIndexCompatible. This parameter was removed by 5f173040.Attached is a patch to remove it from the comment.
Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Fri, Feb 04, 2022 at 09:08:22AM +0900, Fujii Masao wrote:
On 2022/02/04 1:46, Yugo NAGATA wrote:
I found a old parameter name 'heapRelation' in the comment
of CheckIndexCompatible. This parameter was removed by 5f173040.Attached is a patch to remove it from the comment.
It looks like this parameter was removed in 5f17304.
Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?
+1
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
Hello, Fujii-san,
On Fri, 4 Feb 2022 09:08:22 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
On 2022/02/04 1:46, Yugo NAGATA wrote:
Hello,
I found a old parameter name 'heapRelation' in the comment
of CheckIndexCompatible. This parameter was removed by 5f173040.Attached is a patch to remove it from the comment.
Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"?
Agreed. I updated the patch to add a comment about 'oldId'.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
Attachments:
v2_fix_CheckIndexCompatible_comment.patchtext/x-diff; name=v2_fix_CheckIndexCompatible_comment.patchDownload+1-1
On 2022/02/07 19:14, Yugo NAGATA wrote:
Agreed. I updated the patch to add a comment about 'oldId'.
Thanks for updating the patch! I slightly modified the patch and pushed it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
On Fri, 18 Feb 2022 12:22:32 +0900
Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
On 2022/02/07 19:14, Yugo NAGATA wrote:
Agreed. I updated the patch to add a comment about 'oldId'.
Thanks for updating the patch! I slightly modified the patch and pushed it.
Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
--
Yugo NAGATA <nagata@sraoss.co.jp>