Feb 2022

4 commits
Remove PostgreSQL::Test::Utils::perl2host completely
20 Feb 2022Andrew Dunstanmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+3 moreAlso in: fairywren is generating bogus BASE_BACKUP commands (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #171 of 1 reviewer saw the final version

The commit exactly matches the first patch of the two-patch series in #17 after excluding Git index metadata, deleting perl2host and adjusting callers across 17 files. This February 19 attachment is later than both January attachments in thread #45395, so that thread's from_discussion attribution is superseded by the matching attached patch here.

  • Andres Freundsaw the final versionLLM analysis, 85% sureAndres raised the risk of backpatched bugfixes breaking older branches in #19, prompting Andrew's commitment to backpatch the cleanup in #20.
Remove most msys special processing in TAP tests
20 Feb 2022Andrew Dunstanmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+3 more
LLM analysis, 97% surepart of a posted patchsetlight changesfrom patchset #171 of 1 reviewer saw the final version

The commit takes the second patch of the two-patch series in #17, removing MSYS-specific processing across six files. Its only additional edit changes command_like_safe to command_like in src/bin/pg_ctl/t/001_start_stop.pl.

  • Andres Freundsaw the final versionLLM analysis, 92% sureAndres raised the risk of future backpatched fixes breaking older branches in #19, prompting Andrew's commitment to backpatch the cleanup in #20, which Andres endorsed in #21.
Ensure the right perl is used for TAP tests on msys
20 Feb 2022Andrew Dunstanmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #141 of 1 reviewer saw the final version

The changes to config/check_modules.pl, configure.ac and generated configure match #14 exactly apart from rebase offsets and Git metadata. They export __CONFIG_HOST_OS__ and reject MSYS Perl when the configured target is not MSYS.

  • Andres Freundsaw the final versionLLM analysis, 97% sureReviewing the inline design before attachment, Andres explained why MSYSTEM could disagree with host_os in #11 and accepted the exported-host_os solution in #13, which #14 implements.
Disable perl2host() processing in TAP tests
17 Feb 2022Andrew Dunstanmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The one-line change in src/test/perl/PostgreSQL/Test/Utils.pm exactly implements Andrew's inline patch in #1, making perl2host return its argument unconditionally. It predates both attached patchsets.

  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres explicitly supported the inline disabling patch in #2 while requesting a separate guard against incompatible Perl and build-target combinations.

Credits across 4 commits

Author
Andrew DunstanLLM3
Committer
Andrew Dunstan4

N LLM means N of the credits come from LLM analysis, not from commit trailers.