Tab completion not listing schema list for create/alter publication for all tables in schema

Started by vignesh Cabout 4 years ago3 messageshackers

vignesh21@gmail.com

about 4 years ago

Hi,

I noticed that the following commands "CREATE PUBLICATION pub1 FOR ALL
TABLES IN SCHEMA" and "ALTER PUBLICATION pub1 ADD ALL TABLES IN
SCHEMA" does not complete with the schema list. I feel this is because
of the following code in tab-complete.c:
.........
COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_schemas
" AND nspname NOT LIKE E'pg\\\\_%'",
"CURRENT_SCHEMA");
.........
Here "pg\\\\_%" should be "pg\\\\_%%".
Attached a patch to handle this.
Thoughts?

Regards,
Vignesh

Tom Lane

tgl@sss.pgh.pa.us

about 4 years ago

In reply to: vignesh C (#1)

Re: Tab completion not listing schema list for create/alter publication for all tables in schema

vignesh C <vignesh21@gmail.com> writes:

Here "pg\\\\_%" should be "pg\\\\_%%".

Right you are. Patch pushed, thanks!

regards, tom lane

vignesh C

vignesh21@gmail.com

about 4 years ago

In reply to: Tom Lane (#2)

Re: Tab completion not listing schema list for create/alter publication for all tables in schema

On Mon, Mar 14, 2022 at 5:23 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

vignesh C <vignesh21@gmail.com> writes:

Here "pg\\\\_%" should be "pg\\\\_%%".

Right you are. Patch pushed, thanks!

Thanks for pushing the patch.

Regards,
Vignesh

Tab completion not listing schema list for create/alter publication for all tables in schema

Attachments: