Mar 2022

5 commits
Print information about type of test and subdirectory before running tests.
31 Mar 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #174 of 4 reviewers saw the final version

All seven banner insertions in src/Makefile.global.in come from #17; the committed strings distinguish check from install-check instead of saying tests, implementing Tom's suggestion in #33 and Andres's refinement in #35.

  • Robert Haassaw the final versionLLM analysis, 88% sureRobert endorsed the concrete banner-output proposal in #14, before its attachment in #17, with only banner wording and additional test categories subsequently refined.
  • Daniel Gustafssonsaw the final versionLLM analysis, 87% sureDaniel explicitly endorsed the illustrated banner output in #15 before the prototype attachment, then explained its CI usefulness in #18.
  • Tom Lanesaw the final versionLLM analysis, 100% sureTom reviewed the prototype, proposed distinguishing check from installcheck in #33, and accepted the resulting wording in #37.
  • Thomas Munrosaw the final versionLLM analysis, 98% sureThomas endorsed the output improvement in #41 and argued that it would also be useful on older branches.
In basebackup_to_shell tests, properly set up pg_hba.conf.
31 Mar 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 87% suremodified before commitmoderate changesfrom patchset #592 of 3 reviewers saw the final version

The commit retains the auth_extra addition proposed in #59, fixes its malformed init call, preserves CREATE USER rather than ALTER USER, and adds explanatory comments in t/001_basic.pl. Robert identified both defects in #60, having already explained the necessary combination in #57.

  • Tom Lanesaw the final versionLLM analysis, 94% sureTom reported the landed test's SSPI failures in #48 and endorsed using auth_extra while still creating the user in #61, which matches the committed correction.
  • Andres Freundsaw an earlier versionLLM analysis, 90% sureAndres traced the missed failure to CI's Unix-socket configuration and conditional SSPI setup in #49, before the authentication correction was developed.
  • Robert Haassaw the final versioncommittercommitted the patch
Add .gitignore for basebackup_to_shell.
30 Mar 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #461 of 1 reviewer saw the final version

The four-line contrib/basebackup_to_shell/.gitignore addition exactly matches #46, excluding abbreviated diff index hashes; Tom confirmed pushing Nathan's patch in #47.

  • Tom Lanesaw the final versioncommittercommitted the patch
basebackup_to_shell: Add TAP test.
30 Mar 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 98% surepart of a posted patchsetlight changesfrom patchset #301 of 3 reviewers saw the final version

The commit takes the complete TAP-test component of #30, with identical Makefile and t/001_basic.pl diffs; the separate documentation and temporary .cirrus.yml components are outside this commit.

  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres proposed gzip after diagnosing type con in #26, then checked the successful final-version CI run and reviewed path handling in #32.
  • Thomas Munrosaw an earlier versionLLM analysis, 96% sureThomas ran Windows tests, identified broken path escaping in #10, and reported the subsequent timeout in #24, before the test switched to gzip and decompression.
  • Andrew Dunstansaw an earlier versionLLM analysis, 94% sureAndrew explained why type con hangs in #27 and recommended gzip --fast in #29, before the revised gzip-based test was attached.
Document basebackup_to_shell.required_role.
30 Mar 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: [PATCH v2] use has_privs_for_role for predefined roles (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #30

The commit exactly matches the 17-line documentation component of #30 in doc/src/sgml/basebackup-to-shell.sgml, excluding the series' TAP-test and CI components. The supplied verdict for thread #45017 confirms that it only reported the omission; Joe Conway's credit is for that report, not patch review.

Credits across 5 commits

Author
Robert HaasLLM2
Andres FreundLLM1
Andrew DunstanLLM1
Nathan BossartLLM1
Reviewer
Robert Haascommitter1
Tom Lanecommitter1
Committer
Robert Haas3
Andres Freund1
Tom Lane1

N LLM means N of the credits come from LLM analysis, not from commit trailers.