Unhyphenation of crash-recovery
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45657psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 03:12 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t45657_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t45657_1 && git checkout t45657_1Patchset v1 (message #1) is on t45657_1
Hello, this is a derived topic from [1]/messages/by-id/20220316.091913.806120467943749797.horikyota.ntt@gmail.com, summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.
regards.
[1]: /messages/by-id/20220316.091913.806120467943749797.horikyota.ntt@gmail.com
--
Kyotaro Horiguchi
NTT Open Source Software Center
Hi
On March 15, 2022 6:25:09 PM PDT, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.
I don't see the point of this kind of change.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
On Tue, Mar 15, 2022 at 9:39 PM Andres Freund <andres@anarazel.de> wrote:
On March 15, 2022 6:25:09 PM PDT, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.I don't see the point of this kind of change.
It seems like better grammar to me, although whether it is worth the
effort to go fix everything of this kind is certainly debatable.
--
Robert Haas
EDB: http://www.enterprisedb.com
On 16.03.22 02:25, Kyotaro Horiguchi wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.
Most changes in this patch are not the correct direction. The hyphens
are used to group compound adjectives before nouns. For example,
simple crash-recovery cases
means
simple (crash recovery) cases
rather than
simple crash (recovery cases)
if it were without hyphens.
At Thu, 17 Mar 2022 07:42:42 +0100, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote in
On 16.03.22 02:25, Kyotaro Horiguchi wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.Most changes in this patch are not the correct direction. The hyphens
are used to group compound adjectives before nouns. For example,simple crash-recovery cases
means
simple (crash recovery) cases
rather than
simple crash (recovery cases)
if it were without hyphens.
Really? The latter recognization doesn't seem to make sense. I might
be too-trained so that I capture "(crash|archive|blah) recovery" as
implicit compound words. But anyway there's no strong reason to be
aggressive to unhyphenate compound words.
"point-in-time-recovery" and "(during) emergency-recovery operations"
seem like better be unhyphnated, but now I'm not sure it is really so.
Thanks for the comments.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
On Thu, Mar 17, 2022 at 2:42 AM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
On 16.03.22 02:25, Kyotaro Horiguchi wrote:
Hello, this is a derived topic from [1], summarized as $SUBJECT.
This just removes useless hyphens from the words
"(crash|emergency)-recovery". We don't have such wordings for "archive
recovery" This patch fixes non-user-facing texts as well as
user-facing ones.Most changes in this patch are not the correct direction. The hyphens
are used to group compound adjectives before nouns. For example,simple crash-recovery cases
means
simple (crash recovery) cases
rather than
simple crash (recovery cases)
if it were without hyphens.
I agree with that as a general principle, but I also think the
particular case you've chosen here is a good example of another
principle: sometimes it just doesn't matter very much. A case of crash
recovery that happens to be simple is pretty much the same thing as a
case of recovery that is simple and involves a crash. My understanding
of English grammar is that one typically does not hyphenate unless it
is required to avoid confusion. A quick Google search suggests this
example:
Mr Harper had a funny smelling dog
We must try to figure out whether the smell of the dog is funny or
whether the dog itself is both funny and smelling. If we hyphenate
funny-smelling, then it's clear that it is the smell of the dog that
is funny and not the dog itself. But in your example I cannot see that
there is any similar ambiguity. Recovery cases can involve a crash,
and crash recovery can have cases, and what's the difference, anyway?
So I wouldn't hyphenate it, but I also wouldn't spend a lot of time
arguing if someone else did. Except maybe that's exactly what I am
doing. Perhaps I should find something else to do.
--
Robert Haas
EDB: http://www.enterprisedb.com