New compiler warning from btree dedup code

Started by Tom Laneabout 4 years ago2 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

I just noticed that if I build without asserts on my Mac laptop
(using Apple's latest clang, 13.1.6) I get

nbtdedup.c:68:8: warning: variable 'pagesaving' set but not used [-Wunused-but-set-variable]
Size pagesaving = 0;
^
1 warning generated.

Apparently, late-model clang can figure out that the variable
is incremented but not otherwise used. This is enough to
shut it up, but I wonder if you have another preference:

-   Size        pagesaving = 0;
+   Size        pagesaving PG_USED_FOR_ASSERTS_ONLY = 0;

regards, tom lane

In reply to: Tom Lane (#1)
Re: New compiler warning from btree dedup code

That approach seems fine. Thanks.--
Peter Geoghegan