May 2022

8 commits
Disable 031_recovery_conflict.pl until after minor releases.
9 May 2022Andres FreundREL_14_STABLE14.3REL_13_STABLE13.7REL_12_STABLE12.11REL_11_STABLE11.16REL_10_STABLE10.21
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit adds plan skip_all to src/test/recovery/t/031_recovery_conflict.pl, implementing the decision in #32 after Tom Lane reported another failure in #29. No attachment contains this whole-file disablement.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom reported that the partial disablement still failed in #29 and argued for disabling the entire test before release in #31, which Andres accepted.
Temporarily skip recovery deadlock test in back branches.
6 May 2022Andres FreundREL_14_STABLE14.3REL_13_STABLE13.7REL_12_STABLE12.11REL_11_STABLE11.16REL_10_STABLE10.21
LLM analysis, 100% surelanded as postedfrom patchset #251 of 1 reviewer saw the final version

The added lines exactly match #25: a SKIP block surrounds only the recovery-deadlock section of src/test/recovery/t/031_recovery_conflict.pl.

  • Tom Lanesaw the final versionLLM analysis, 90% sureTom examined failures and the reverted timing fix in #22, then accepted disabling only the failing test in #24; his explicit approval in #26 came after this commit and is excluded.
Backpatch addition of pump_until() more completely.
6 May 2022Andres FreundREL_14_STABLE14.3REL_13_STABLE13.7REL_12_STABLE12.11REL_11_STABLE11.16Also in: pgsql: Backpatch addition of wait_for_log(), pump_until().
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit removes local pump_until definitions from src/test/recovery/t/013_crash_restart.pl and src/test/recovery/t/022_crash_temp_files.pl and supplies timeout arguments to the shared helper. It implements the warning report in #20 and Andres's response in #21, without an attached patch.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom reported duplicate pump_until definitions and their check-world warnings in #20, directly prompting this cleanup.
Fix timing issue in deadlock recovery conflict test.
4 May 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+3 more
LLM analysis, 100% surelanded as postedfrom patchset #191 of 1 reviewer saw the final version

All 11 added lines exactly match #19, increasing max_standby_streaming_delay around the deadlock test and restarting and reconnecting the standby before restoring the original setting.

  • Tom Lanesaw the final versionLLM analysis, 94% sureTom reported the incorrect buffer-pin cancellation in #13 and investigated reproduction in #15, prompting the subsequent test-only timing adjustment.
Backpatch 031_recovery_conflict.pl.
3 May 2022Andres FreundREL_14_STABLE14.3REL_13_STABLE13.7REL_12_STABLE12.11REL_11_STABLE11.16REL_10_STABLE10.21
LLM analysis, 87% surepart of a posted patchsetlight changesfrom patchset #101 of 1 reviewer saw the final version

This lands the backpatch component announced in #10, adding src/test/recovery/t/031_recovery_conflict.pl with tablespace checks disabled and per-conflict statistics checks omitted. Shared helpers replace the inlined implementations described there, following #11; missing attachment files prevent an exact comparison.

  • Tom Lanesaw the final versionLLM analysis, 96% sureTom supported the backpatch plan and recommended backpatching the shared test helpers in #11, which Andres confirmed implementing in #12.
Fix possibility of self-deadlock in ResolveRecoveryConflictWithBufferPin().
3 May 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+3 more
LLM analysis, 90% surepart of a posted patchsetlight changesfrom patchset #101 of 1 reviewer saw the final version

This lands the server-fix component of #10: src/backend/storage/ipc/standby.c sets got_standby_delay_timeout in the signal handler and performs cancellation in normal execution. The discussion establishes the source and approach, but the unavailable attachments prevent verifying every edit.

  • Tom Lanesaw the final versionLLM analysis, 97% sureTom insisted on moving unsafe signal-handler work into normal execution in all branches in #8 and addressed the submitted patch's formatting question in #11.
Backpatch addition of wait_for_log(), pump_until().
3 May 2022Andres FreundREL_14_STABLE14.3REL_13_STABLE13.7REL_12_STABLE12.11REL_11_STABLE11.16REL_10_STABLE10.21
LLM analysis, 97% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit backpatches wait_for_log and pump_until into the shared Perl infrastructure. In #10 these helpers were described as inlined in the test attachment; #11 instead recommended backpatching their shared implementations.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom proposed backpatching the shared helpers for future reuse in #11, and Andres confirmed taking that recommendation in #12.
Add tests for recovery deadlock conflicts.
3 May 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 87% surepart of a posted patchsetlight changesfrom patchset #10

This lands the HEAD test component announced in #10, adding a prepared-transaction lock and conflicting buffer pin to src/test/recovery/t/031_recovery_conflict.pl. Andres confirms committing the test extension separately before the server fix in #12; the missing attachment prevents exact comparison.

Credits across 8 commits

Author
Andres FreundLLM5
Committer
Andres Freund8

N LLM means N of the credits come from LLM analysis, not from commit trailers.