Fix typo in comment
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45919psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 02:43 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t45919_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t45919_1 && git checkout t45919_1Patchset v1 (message #1) is on t45919_1
On 2022-May-06, Zaorang Yang wrote:
Maybe, the first letter of comments in postinit.c should be capitalized.
Hmm, typically these one-line comments are not "full sentences", so they
don't have capitals and no ending periods either. I wouldn't like the
endless stream of patches that would result if we let this go in.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
On 6 May 2022, at 14:50, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
On 2022-May-06, Zaorang Yang wrote:
Maybe, the first letter of comments in postinit.c should be capitalized.
Hmm, typically these one-line comments are not "full sentences", so they
don't have capitals and no ending periods either. I wouldn't like the
endless stream of patches that would result if we let this go in.
Agreed. A quick grep turns up a fair number of such comments:
$ git grep "^\s*\/\* [a-z].\+\*\/$" src/ | wc -l
16588
If anything should be done to this it would perhaps be better to add to
pgindent or a similar automated process. If anything.
--
Daniel Gustafsson https://vmware.com/
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
On 2022-May-06, Zaorang Yang wrote:
Maybe, the first letter of comments in postinit.c should be capitalized.
Hmm, typically these one-line comments are not "full sentences", so they
don't have capitals and no ending periods either. I wouldn't like the
endless stream of patches that would result if we let this go in.
There is no project style guideline suggesting one over the other, so
I think we should just leave it alone.
regards, tom lane