CI
Applieswon't retry4y behind master
Buildsuccess2m 13s / 4m 08s
Tests654 / 654
GitHub runGitHub branchCI history
Participants
Andrew Dunstan
Andrew Dunstan
Tom Lane
Tom Lane
Attachments
Download Latest Patchset
+6-6
Show all attachments
Show all patchsets
Thread Outline
#1Andrew DunstanAndrew Dunstan
Jun 11, 2022
#2Tom Lane↳Tom Laneto Andrew Dunstan (#1)
Jun 11, 2022
#3Andrew Dunstan↳Andrew Dunstanto Tom Lane (#2)
Jun 12, 2022

Subscription tests vs log_error_verbosity

Started by Andrew Dunstanover 4 years ago3 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t46089
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 02:37 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t46089_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t46089_1 && git checkout t46089_1

Patchset v1 (message #1) is on t46089_1

Jump to latest
#1Andrew Dunstan
Andrew Dunstan
andrew@dunslane.net

I have just got to the bottom of why the new subscription tests
027_nosuperuser.pl and 029_on_error.pl have been failing for me - it's
because my test setup has log_error_verbosity set to 'verbose'. Either
we should force log_error_verbosity to 'default' for these tests, or we
should make the regexes we're testing for more forgiving as in the attached.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachments:

t46089_1
fix-subscription-tests-verbose-errors.patchtext/x-patch; charset=UTF-8; name=fix-subscription-tests-verbose-errors.patchDownload+6-6
#2Tom Lane
Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#1)
Re: Subscription tests vs log_error_verbosity

Andrew Dunstan <andrew@dunslane.net> writes:

I have just got to the bottom of why the new subscription tests
027_nosuperuser.pl and 029_on_error.pl have been failing for me - it's
because my test setup has log_error_verbosity set to 'verbose'. Either
we should force log_error_verbosity to 'default' for these tests, or we
should make the regexes we're testing for more forgiving as in the attached.

+1 for the second answer. I don't like forcing parameter settings
that we don't absolutely have to --- it reduces our test coverage.
(Admittedly, changing log_error_verbosity in particular is probably
not giving up much coverage, but as a general principle it's bad.)

regards, tom lane

#3Andrew Dunstan
Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#2)
Re: Subscription tests vs log_error_verbosity

On 2022-06-11 Sa 14:52, Tom Lane wrote:

Andrew Dunstan <andrew@dunslane.net> writes:

I have just got to the bottom of why the new subscription tests
027_nosuperuser.pl and 029_on_error.pl have been failing for me - it's
because my test setup has log_error_verbosity set to 'verbose'. Either
we should force log_error_verbosity to 'default' for these tests, or we
should make the regexes we're testing for more forgiving as in the attached.

+1 for the second answer. I don't like forcing parameter settings
that we don't absolutely have to --- it reduces our test coverage.
(Admittedly, changing log_error_verbosity in particular is probably
not giving up much coverage, but as a general principle it's bad.)

Yeah, Done that way.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

← Back to Topics