Fix obsoleted comments for function prototypes

Started by Richard Guoover 3 years ago4 messageshackers
Jump to latest
#1Richard Guo
guofenglinux@gmail.com

While doing the search in [1]/messages/by-id/CAMbWs489+u6P_9qMjABsse0dNNBr36MA1SX5Ss7yZ7TD86mfKQ@mail.gmail.com, I spotted several places where the
comments for the function prototypes are obsoleted. For instance,
btree_desc() and btree_identify() are now located in nbtdesc.c but the
comment in nbtxlog.h is still claiming they are in nbtxlog.c.

Fix these places with the attached. With high possibility there are
other places with this kind of obsoleted comments, but I don't know how
to find them all :-(.

Thanks
Richard

[1]: /messages/by-id/CAMbWs489+u6P_9qMjABsse0dNNBr36MA1SX5Ss7yZ7TD86mfKQ@mail.gmail.com
/messages/by-id/CAMbWs489+u6P_9qMjABsse0dNNBr36MA1SX5Ss7yZ7TD86mfKQ@mail.gmail.com

Attachments:

v1-0001-Resolve-obsoleted-comments-for-function-prototype.patchapplication/octet-stream; name=v1-0001-Resolve-obsoleted-comments-for-function-prototype.patchDownload+14-8
#2Michael Paquier
michael@paquier.xyz
In reply to: Richard Guo (#1)
Re: Fix obsoleted comments for function prototypes

On Tue, Aug 02, 2022 at 05:06:44PM +0800, Richard Guo wrote:

While doing the search in [1], I spotted several places where the
comments for the function prototypes are obsoleted. For instance,
btree_desc() and btree_identify() are now located in nbtdesc.c but the
comment in nbtxlog.h is still claiming they are in nbtxlog.c.

Fix these places with the attached. With high possibility there are
other places with this kind of obsoleted comments, but I don't know how
to find them all :-(.

These declarations are linked to comments with their file paths, so
making that automated looks rather complicated to me. I have looked
at the surroundings without noticing anything obvious, so what you
have caught here sounds fine to me, good catches :)
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Fix obsoleted comments for function prototypes

On Tue, Aug 02, 2022 at 07:25:49PM +0900, Michael Paquier wrote:

These declarations are linked to comments with their file paths, so
making that automated looks rather complicated to me. I have looked
at the surroundings without noticing anything obvious, so what you
have caught here sounds fine to me, good catches :)

Done as of 245e14e.
--
Michael

#4Richard Guo
guofenglinux@gmail.com
In reply to: Michael Paquier (#3)
Re: Fix obsoleted comments for function prototypes

On Thu, Aug 4, 2022 at 4:38 PM Michael Paquier <michael@paquier.xyz> wrote:

On Tue, Aug 02, 2022 at 07:25:49PM +0900, Michael Paquier wrote:

These declarations are linked to comments with their file paths, so
making that automated looks rather complicated to me. I have looked
at the surroundings without noticing anything obvious, so what you
have caught here sounds fine to me, good catches :)

Done as of 245e14e.

Thank you Michael!

Thanks
Richard