Fix inconsistencies GUC categories

Started by Shinya Katoover 3 years ago3 messageshackers
Jump to latest
#1Shinya Kato
Shinya11.Kato@oss.nttdata.com

Hi,

It appears that config.sgml and pg_settings have not been updated, even
though a new subcategory was added in 249d649. a55a984 may have been
missed in the cleaning.
--
Category is 'CONNECTIONS AND AUTHENTICATION' and subcategory is
'Connection Settings' at config.sgml.
Category is 'CONNECTIONS AND AUTHENTICATION' and subcategory is
'Connection Settings' at pg_settings.
Category is 'CONNECTIONS AND AUTHENTICATION' and subcategory is 'TCP
settings' at postgresql.conf.sample.
--

I would like to unify the following with config.sgml as in a55a984.
--
Category is 'REPORTING AND LOGGING' and subcategory is 'PROCESS TITLE'
at config.sgml.
Category is 'REPORTING AND LOGGING' and subcategory is 'PROCESS TITLE'
at pg_settings.
Category is 'PROCESS TITLE' and subcategory is none at
postgresql.conf.sample.
--

Trivial changes were made to the following short_desc.
--
recovery_prefetch
enable_group_by_reordering
stats_fetch_consistency
--

I've attached a patch.
Thoghts?

--
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachments:

v1-fix-inconsistencies-guc-categories.patchtext/x-diff; name=v1-fix-inconsistencies-guc-categories.patchDownload+19-12
#2Michael Paquier
michael@paquier.xyz
In reply to: Shinya Kato (#1)
Re: Fix inconsistencies GUC categories

On Thu, Aug 04, 2022 at 08:09:51PM +0900, Shinya Kato wrote:

I would like to unify the following with config.sgml as in a55a984.
--
Category is 'REPORTING AND LOGGING' and subcategory is 'PROCESS TITLE' at
config.sgml.
Category is 'REPORTING AND LOGGING' and subcategory is 'PROCESS TITLE' at
pg_settings.

Yep. I agree with these changes, even for
client_connection_check_interval.

Category is 'PROCESS TITLE' and subcategory is none at
postgresql.conf.sample.

Yep. This change sounds right as well.
--
Michael

#3Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#2)
Re: Fix inconsistencies GUC categories

On Sat, Aug 06, 2022 at 09:54:36PM +0900, Michael Paquier wrote:

Yep. This change sounds right as well.

Done as of 0b039e3. Thanks, Kato-san.
--
Michael